From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#74902: 31.0.50; Segfault when deleting frames Date: Fri, 10 Jan 2025 12:26:50 +0100 Message-ID: <87bjweq58l.fsf@gmail.com> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> <874j2bj6wr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Steven Allen , 74902@debbugs.gnu.org To: Eli Zaretskii , Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 10 12:27:18 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tWDAb-0006Z1-Rx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jan 2025 12:27:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tWDAQ-0008L9-8I; Fri, 10 Jan 2025 06:27:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWDAN-0008Ir-H7 for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2025 06:27:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tWDAM-0005dJ-Va for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2025 06:27:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=C/eKrlCIiLnd0pNb5458fqOAtf+x5KKwhphuA3bAHiw=; b=JVjsafIuX3/s6emw9nvSL2W/MMIbpspBY9s6DD5DX3gvXijSKQPFR8SCHgxgm0MhUWttjfbUMfPr+Nc4UiDrsD8BruM3abG8U9Umj0CTh1+jgRyyWRPSJIUGMIonrn31GF7pfQZ4bdtRBBhzq0bhHzXV/P6uqVkrKJFktc79lvUd0WzDM7qEtvGd7S8ZZga4NcTFyNqaWrRmQ4+5BDOaAZnrFWpOt1J0aBZTwAsG3Xwa/8W0CjBa3ungjVSNFd0XwGHbNSDIQoo/IctS0WSamcOOffEVPmQeFtfAPpe+Fh9UMaB0OOwA9kqrqUhy0aeuSHHxBSZrPAOhqpH0ldHpSg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tWDAM-0004En-HH for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2025 06:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jan 2025 11:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74902 X-GNU-PR-Package: emacs Original-Received: via spool by 74902-submit@debbugs.gnu.org id=B74902.173650842116282 (code B ref 74902); Fri, 10 Jan 2025 11:27:02 +0000 Original-Received: (at 74902) by debbugs.gnu.org; 10 Jan 2025 11:27:01 +0000 Original-Received: from localhost ([127.0.0.1]:56547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWDAK-0004EX-II for submit@debbugs.gnu.org; Fri, 10 Jan 2025 06:27:00 -0500 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:52372) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tWDAI-0004EH-RK for 74902@debbugs.gnu.org; Fri, 10 Jan 2025 06:27:00 -0500 Original-Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3862ca8e0bbso1513164f8f.0 for <74902@debbugs.gnu.org>; Fri, 10 Jan 2025 03:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736508412; x=1737113212; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=C/eKrlCIiLnd0pNb5458fqOAtf+x5KKwhphuA3bAHiw=; b=OGvEhoZnG7K9CheRCQH5gVQVjYzbUPd6fB++2ftiQBEL2xdleVkMUXBMycM3O5Twdw 8vojSiW4h635CW8UPrAI86ilCpSJvtzkZa1O79n9D3sCXa8IkEVoif+2sKGXKV40O12z qECldbH9VukL280vDLFJp3Czr10I0wOqpgSBt0tHDOezpEcEKoJthFJJsdjsWIs1YR3A D8ceKcfQS6mIYrIM3s/X2XVcYsdbMYjK15mvyJiCT4lBxKRuTA8n48FJfR5+9w5pRBXb WcgbKjJxI0N7NxQuUyd9LtHTqZGxDlUJVLMmJQ9/7vEJ+gb5liccnXJrHuncpFgKue1Y iPnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736508412; x=1737113212; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C/eKrlCIiLnd0pNb5458fqOAtf+x5KKwhphuA3bAHiw=; b=eIxAJwcsdun8VaDCDkcUNFfqxaQkc90ZnaEN260O1eGneEYMYXguLnxdrnew+1y+tR PkaaSssx05ldywGUUeBAAlID1jC//+IdGrqkPn5ts3mXy7Xj9fQLPhGSqwLAu2vKoRwj ewIlvhCKBn2shYla89iktcNSupz6mHf7KHmxnd4IyXxmnNbfGYVilKXSlrn41J4D4YuN mrSxELEwTMW68aDSEEL4kbT1xxxfaa0UKviHeDj1yYVAmcLq0ZMJB8CP6XOn9bIbKtRl XZmHuOsznn268/Z09dGAKWopk9Riw5Ng8TC1ht5gQenxGJwNKDdODXo9bkbffPsFaYgk 4cHQ== X-Forwarded-Encrypted: i=1; AJvYcCVFYa17cjg3vyQedCBgrDAOugjLYnWTmBSqMb0khzxYC+9WIMfWFsiygOGtmPfGY9HZApOEtA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyyMcYxRh1EZzuUMXM4qLxH1VmxjxhM1iEOG4aQrsWE4gtv91gv rS0o9OI9wwepFNHzu1L7o2camBaUTX8zcNJD/BnIlb+kz5vn7Aw8IMsf6w== X-Gm-Gg: ASbGncuw+qvH5mc6K4M/X4t/PhewKRAOQ7fIeUWZM6f+28jPDl+QDG2a5R6KSQSDku2 WvAge+3+eTj3X7SHkZKmHw/WylmiyvwQmenmS2vepvEyFth4TQU0S2UeVgSFmkM3RkQhFtqJaHq wsSnEw2rLW2cY4zVF1FAK13c6A1XikZCsWVRB7vNy8W9E+r2JII3eTg26uzXrfaJ4TJBlE+Zz8t nDeGdrS5QSmqv50CgPRJ0BcmEglDaorStvnNY1P3GEk X-Google-Smtp-Source: AGHT+IGic/0zduwFb3PhuR7JjmBR7zm31Owm1VJh9kcW5uRwj9SzCbBX/4txtGj7m7qxEazd/Q5S5g== X-Received: by 2002:a05:6000:1ac9:b0:385:df73:2f42 with SMTP id ffacd0b85a97d-38a873213dfmr9537498f8f.32.1736508411435; Fri, 10 Jan 2025 03:26:51 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb51:2075:f98f:a3af:3706]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1cf2sm4318868f8f.99.2025.01.10.03.26.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 03:26:50 -0800 (PST) In-Reply-To: <874j2bj6wr.fsf@gmail.com> (Robert Pluim's message of "Tue, 07 Jan 2025 10:43:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298878 Archived-At: >>>>> On Tue, 07 Jan 2025 10:43:32 +0100, Robert Pluim said: >>>>> On Tue, 31 Dec 2024 08:31:04 -0800, Steven Allen said: Steven> Eli Zaretskii writes: >>> Thanks. I guess we also need a FRAME_LIVE_P test in >>> gui_consider_frame_title? Steven> I've attached a patch for that but note that it doesn't actually help in Steven> this situation because the frame isn't deleted until: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 Steven> Whereas the crash happens here, 36 lines above: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 Robert> gui_consider_frame_title looks at Vframe_list, so removing the Robert> to-be-deleted frame from it should be enough (unless this crash was Robert> with my patch applied?) Eli, did you still want me to push the change to master? Robert --