From: Chong Yidong <cyd@stupidchicken.com>
To: David Caldwell <david@porkrind.org>
Cc: 754@emacsbugs.donarmstrong.com
Subject: bug#754: Can't cancel dabbrev-expand (M-/) with C-g
Date: Thu, 21 Aug 2008 11:48:34 -0400 [thread overview]
Message-ID: <87abf61i99.fsf@cyd.mit.edu> (raw)
> If I have many buffers open (284 at the moment) and if I run
> dabbrev-expand (M-/) to expand the word under my buffers then it
> searches through every buffer and takes an understandably long
> time. If I mispelled the word fragment then it never has a hope of
> finding it and I'd like to cancel the operation. But C-g does not work
> for some reason and so I have to wait a good 5 to 10 seconds for it to
> finish scanning all my buffers. This gets very frustrating after the
> third or fourth time.
I don't see why C-g wouldn't work here. Could you apply the following
patch and see if the problem persists? (This is not a fix; it's an
attempt to diagnose the problem. As far as I know, quitting should not
be inhibited here.)
*** emacs/lisp/dabbrev.el.~1.83.2.3.~ 2008-01-06 21:44:58.000000000 -0500
--- emacs/lisp/dabbrev.el 2008-08-21 11:43:59.000000000 -0400
***************
*** 777,783 ****
(setq dabbrev--friend-buffer-list
(dabbrev--make-friend-buffer-list))))
;; Walk through the buffers till we find a match.
! (let (expansion)
(while (and (not expansion) dabbrev--friend-buffer-list)
(setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
(set-buffer dabbrev--last-buffer)
--- 777,784 ----
(setq dabbrev--friend-buffer-list
(dabbrev--make-friend-buffer-list))))
;; Walk through the buffers till we find a match.
! (let ((inhibit-quit nil)
! expansion)
(while (and (not expansion) dabbrev--friend-buffer-list)
(setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
(set-buffer dabbrev--last-buffer)
next reply other threads:[~2008-08-21 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 15:48 Chong Yidong [this message]
2008-08-21 19:30 ` bug#754: Can't cancel dabbrev-expand (M-/) with C-g David Caldwell
2009-01-10 4:41 ` David Caldwell
2011-07-06 17:49 ` Lars Magne Ingebrigtsen
2011-07-06 18:05 ` David Caldwell
2011-07-07 17:53 ` Lars Magne Ingebrigtsen
2011-07-07 18:29 ` David Caldwell
-- strict thread matches above, loose matches on Subject: below --
2008-08-20 23:38 David Caldwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87abf61i99.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=754@emacsbugs.donarmstrong.com \
--cc=david@porkrind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).