* bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
@ 2008-09-04 14:31 Stephen Berman
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Berman @ 2008-09-04 14:31 UTC (permalink / raw)
To: emacs-pretest-bug
1. emacs -Q
2. C-h i m gnus RET
3. Click with mouse-1 (or mouse-2) on any of the links under "Other
related manuals", i.e. Message, Emacs-MIME, Sieve, PGG, SASL: nothing
happens.
Typing 'RET' on any of these links, in contrast, DTRT, i.e. goes to the
respective node. Clicking mouse-1 on any of the other links also DTRT.
The following patch fixes the problem for me:
*** emacs/lisp/info.el.~1.542.~ 2008-09-04 16:16:19.000000000 +0200
--- emacs/lisp/info.el 2008-09-04 16:22:24.000000000 +0200
***************
*** 3099,3105 ****
At end of the node's text, moves to the next node, or up if none."
(interactive "e")
(mouse-set-point click)
! (and (not (Info-try-follow-nearest-node))
(save-excursion (forward-line 1) (eobp))
(Info-next-preorder)))
--- 3099,3105 ----
At end of the node's text, moves to the next node, or up if none."
(interactive "e")
(mouse-set-point click)
! (and (not (Info-follow-nearest-node))
(save-excursion (forward-line 1) (eobp))
(Info-next-preorder)))
In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
of 2008-08-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=local
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
@ 2008-09-15 8:34 martin rudalics
2008-09-15 9:25 ` Stephen Berman
0 siblings, 1 reply; 6+ messages in thread
From: martin rudalics @ 2008-09-15 8:34 UTC (permalink / raw)
To: 886; +Cc: Stephen Berman
The fix seems to have the following side-effect: In my .emacs I bind
(define-key Info-mode-map [mouse-1] 'Info-mouse-follow-nearest-node)
Now when I use mouse-1 to just "select" the Info-window I usually get
Info-follow-nearest-node: Point neither on reference nor in menu item description
which is annoying :-(
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
2008-09-15 8:34 bug#886: 23.0.60; Info-mouse-follow-nearest-node fails martin rudalics
@ 2008-09-15 9:25 ` Stephen Berman
2008-09-15 12:11 ` martin rudalics
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Berman @ 2008-09-15 9:25 UTC (permalink / raw)
To: martin rudalics; +Cc: 886
On Mon, 15 Sep 2008 10:34:01 +0200 martin rudalics <rudalics@gmx.at> wrote:
> The fix seems to have the following side-effect: In my .emacs I bind
>
> (define-key Info-mode-map [mouse-1] 'Info-mouse-follow-nearest-node)
> Now when I use mouse-1 to just "select" the Info-window I usually get
>
> Info-follow-nearest-node: Point neither on reference nor in menu item description
>
> which is annoying :-(
>
> martin
Does the following patch fix it?
*** emacs/lisp/info.el.~1.544.~ 2008-09-11 11:49:36.000000000 +0200
--- emacs/lisp/info.el 2008-09-15 11:22:53.000000000 +0200
***************
*** 3123,3129 ****
(Info-goto-node
(Info-extract-menu-item (match-string-no-properties 1)) fork)
t)))
! (error "Point neither on reference nor in menu item description")))
;; Common subroutine.
(defun Info-try-follow-nearest-node (&optional fork)
--- 3123,3130 ----
(Info-goto-node
(Info-extract-menu-item (match-string-no-properties 1)) fork)
t)))
! (unless (eq this-command 'Info-mouse-follow-nearest-node)
! (error "Point neither on reference nor in menu item description"))))
;; Common subroutine.
(defun Info-try-follow-nearest-node (&optional fork)
Steve Berman
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
2008-09-15 9:25 ` Stephen Berman
@ 2008-09-15 12:11 ` martin rudalics
2008-09-15 13:48 ` Stephen Berman
0 siblings, 1 reply; 6+ messages in thread
From: martin rudalics @ 2008-09-15 12:11 UTC (permalink / raw)
To: Stephen Berman; +Cc: 886
> Does the following patch fix it?
>
> *** emacs/lisp/info.el.~1.544.~ 2008-09-11 11:49:36.000000000 +0200
> --- emacs/lisp/info.el 2008-09-15 11:22:53.000000000 +0200
> ***************
> *** 3123,3129 ****
> (Info-goto-node
> (Info-extract-menu-item (match-string-no-properties 1)) fork)
> t)))
> ! (error "Point neither on reference nor in menu item description")))
>
> ;; Common subroutine.
> (defun Info-try-follow-nearest-node (&optional fork)
> --- 3123,3130 ----
> (Info-goto-node
> (Info-extract-menu-item (match-string-no-properties 1)) fork)
> t)))
> ! (unless (eq this-command 'Info-mouse-follow-nearest-node)
> ! (error "Point neither on reference nor in menu item description"))))
>
> ;; Common subroutine.
> (defun Info-try-follow-nearest-node (&optional fork)
Yes - the following seems simpler:
! (eq this-command 'Info-mouse-follow-nearest-node)
! (error "Point neither on reference nor in menu item description")))
I'm not sure though whether we should raise an error for mouse-2 clicks.
But I also fail to understand why we should raise an error at all.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
2008-09-15 12:11 ` martin rudalics
@ 2008-09-15 13:48 ` Stephen Berman
2008-09-17 6:54 ` martin rudalics
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Berman @ 2008-09-15 13:48 UTC (permalink / raw)
To: martin rudalics; +Cc: 886
On Mon, 15 Sep 2008 14:11:38 +0200 martin rudalics <rudalics@gmx.at> wrote:
>> Does the following patch fix it?
>>
>> *** emacs/lisp/info.el.~1.544.~ 2008-09-11 11:49:36.000000000 +0200
>> --- emacs/lisp/info.el 2008-09-15 11:22:53.000000000 +0200
>> ***************
>> *** 3123,3129 ****
>> (Info-goto-node
>> (Info-extract-menu-item (match-string-no-properties 1)) fork)
>> t)))
>> ! (error "Point neither on reference nor in menu item description")))
>>
>> ;; Common subroutine.
>> (defun Info-try-follow-nearest-node (&optional fork)
>> --- 3123,3130 ----
>> (Info-goto-node
>> (Info-extract-menu-item (match-string-no-properties 1)) fork)
>> t)))
>> ! (unless (eq this-command 'Info-mouse-follow-nearest-node)
>> ! (error "Point neither on reference nor in menu item description"))))
>>
>> ;; Common subroutine.
>> (defun Info-try-follow-nearest-node (&optional fork)
>
> Yes - the following seems simpler:
>
> ! (eq this-command 'Info-mouse-follow-nearest-node)
> ! (error "Point neither on reference nor in menu item description")))
Oops, yes of course.
> I'm not sure though whether we should raise an error for mouse-2 clicks.
> But I also fail to understand why we should raise an error at all.
I agree an error here is unnecessary and it would be better to remove
it. I doubt any existing code depends on it.
Steve Berman
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
2008-09-15 13:48 ` Stephen Berman
@ 2008-09-17 6:54 ` martin rudalics
0 siblings, 0 replies; 6+ messages in thread
From: martin rudalics @ 2008-09-17 6:54 UTC (permalink / raw)
To: Stephen Berman; +Cc: 886
> I agree an error here is unnecessary and it would be better to remove
> it. I doubt any existing code depends on it.
I checked in a fix which doesn't raise an error when mouse-1 is involved.
Thanks, martin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-09-17 6:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-15 8:34 bug#886: 23.0.60; Info-mouse-follow-nearest-node fails martin rudalics
2008-09-15 9:25 ` Stephen Berman
2008-09-15 12:11 ` martin rudalics
2008-09-15 13:48 ` Stephen Berman
2008-09-17 6:54 ` martin rudalics
-- strict thread matches above, loose matches on Subject: below --
2008-09-04 14:31 Stephen Berman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).