bug#4144: 23.1.50; VC Annotate for bzr files broken

unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed

* bug#4144: 23.1.50; VC Annotate for bzr files broken
@ 2009-08-14 19:52 ` =C3=93scar?= Fuentes
  2009-08-15  6:24   ` Dan Nicolaescu
  2009-12-06 20:30   ` bug#4144: marked as done (23.1.50; VC Annotate for bzr files broken) Emacs bug Tracking System
  0 siblings, 2 replies; 4+ messages in thread
From: =C3=93scar?= Fuentes @ 2009-08-14 19:52 UTC (permalink / raw)
  To: emacs-pretest-bug

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The Annotate view of bzr files doesn't show author and revision #
information. Seems that emacs does not understand the annotate output of
bzr.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/share/emacs/23.1.50/etc/DEBUG for instructions.

In GNU Emacs 23.1.50.3 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2009-07-31 on qcore
Windowing system distributor `The X.Org Foundation', version 11.0.60900000
configured using `configure  '--with-x-toolkit=lucid''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  show-paren-mode: t
  diff-auto-refine-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
<right> <right> <right> <backspace> <return> <tab> 
C-y C-x C-s C-x b l l v m - c <return> <backspace> 
C-x C-s C-x b <return> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> C-e <left> 
<left> <left> <left> <left> <left> c m a k e . C-x 
C-s C-x b C-g C-x b <return> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> e c h o SPC " r 
p u e <backspace> <backspace> <backspace> <backspace> 
r p <backspace> <backspace> p r u e b a " SPC > > C-x 
C-s M-x g n u s <return> <down> <return> d q <return> 
d q q y C-x b s t a t u <return> <down> g <down> <down> 
m m <up> <up> <down> C-u D y e s <return> <up> m <down> 
m <up> r y e s <return> M-x g n s <backspace> u s <return> 
<return> d q <down> <return> d q <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> q q y <help-echo> h C-x C-c <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
Destroying external MIME viewers
Saving file /home/oscar/.newsrc...
Wrote /home/oscar/.newsrc
Saving /home/oscar/.newsrc.eld...
Saving file /home/oscar/.newsrc.eld...
Wrote /home/oscar/.newsrc.eld
Saving /home/oscar/.newsrc.eld...done
When done with this frame, type C-x 5 0
(No files need saving)
When done with this frame, type C-x 5 0

Load-path shadows:
None found.

-- 
Óscar Fuentes
Desarrollo de Software

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#4144: 23.1.50; VC Annotate for bzr files broken
  2009-08-14 19:52 ` bug#4144: 23.1.50; VC Annotate for bzr files broken =C3=93scar?= Fuentes
@ 2009-08-15  6:24   ` Dan Nicolaescu
  2009-12-06 20:30   ` bug#4144: marked as done (23.1.50; VC Annotate for bzr files broken) Emacs bug Tracking System
  1 sibling, 0 replies; 4+ messages in thread
From: Dan Nicolaescu @ 2009-08-15  6:24 UTC (permalink / raw)
  To: =C3=93scar?= Fuentes; +Cc: 4144

ofv@wanadoo.es. "(Óscar" Fuentes) writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > The Annotate view of bzr files doesn't show author and revision #
  > information. Seems that emacs does not understand the annotate output of
  > bzr.

Try putting the mouse of the version number on the left side of the
buffer, you will get a tooltip with that info.
It's (mis)feature of the vc-bzr backend, and it's annoying that it's
turned on by default, making the vc-annotate output different that for
any other backend...

  > 
  > If Emacs crashed, and you have the Emacs process in the gdb debugger,
  > please include the output from the following gdb commands:
  >     `bt full' and `xbacktrace'.
  > If you would like to further debug the crash, please read the file
  > /usr/local/share/emacs/23.1.50/etc/DEBUG for instructions.
  > 
  > 
  > In GNU Emacs 23.1.50.3 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
  >  of 2009-07-31 on qcore
  > Windowing system distributor `The X.Org Foundation', version 11.0.60900000
  > configured using `configure  '--with-x-toolkit=lucid''
  > 
  > Important settings:
  >   value of $LC_ALL: nil
  >   value of $LC_COLLATE: nil
  >   value of $LC_CTYPE: nil
  >   value of $LC_MESSAGES: nil
  >   value of $LC_MONETARY: nil
  >   value of $LC_NUMERIC: nil
  >   value of $LC_TIME: nil
  >   value of $LANG: en_US.UTF-8
  >   value of $XMODIFIERS: nil
  >   locale-coding-system: utf-8-unix
  >   default-enable-multibyte-characters: t
  > 
  > Major mode: Lisp Interaction
  > 
  > Minor modes in effect:
  >   show-paren-mode: t
  >   diff-auto-refine-mode: t
  >   iswitchb-mode: t
  >   tooltip-mode: t
  >   mouse-wheel-mode: t
  >   menu-bar-mode: t
  >   file-name-shadow-mode: t
  >   global-font-lock-mode: t
  >   font-lock-mode: t
  >   global-auto-composition-mode: t
  >   auto-composition-mode: t
  >   auto-encryption-mode: t
  >   auto-compression-mode: t
  >   column-number-mode: t
  >   line-number-mode: t
  > 
  > Recent input:
  > <right> <right> <right> <backspace> <return> <tab> 
  > C-y C-x C-s C-x b l l v m - c <return> <backspace> 
  > C-x C-s C-x b <return> <down> <down> <down> <down> 
  > <down> <down> <down> <down> <down> <down> <down> <down> 
  > <down> <down> <down> <down> <down> <down> C-e <left> 
  > <left> <left> <left> <left> <left> c m a k e . C-x 
  > C-s C-x b C-g C-x b <return> <left> <left> <left> <left> 
  > <left> <left> <left> <left> <left> <left> <left> <left> 
  > <left> <left> <left> <left> <left> <left> <left> <left> 
  > <left> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> <backspace> <backspace> 
  > <backspace> <backspace> <backspace> e c h o SPC " r 
  > p u e <backspace> <backspace> <backspace> <backspace> 
  > r p <backspace> <backspace> p r u e b a " SPC > > C-x 
  > C-s M-x g n u s <return> <down> <return> d q <return> 
  > d q q y C-x b s t a t u <return> <down> g <down> <down> 
  > m m <up> <up> <down> C-u D y e s <return> <up> m <down> 
  > m <up> r y e s <return> M-x g n s <backspace> u s <return> 
  > <return> d q <down> <return> d q <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> <return> <return> <return> <return> 
  > <return> <return> q q y <help-echo> h C-x C-c <help-echo> 
  > <help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
  > <help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
  > <menu-bar> <help-menu> <send-emacs-bug-report>
  > 
  > Recent messages:
  > Destroying external MIME viewers
  > Saving file /home/oscar/.newsrc...
  > Wrote /home/oscar/.newsrc
  > Saving /home/oscar/.newsrc.eld...
  > Saving file /home/oscar/.newsrc.eld...
  > Wrote /home/oscar/.newsrc.eld
  > Saving /home/oscar/.newsrc.eld...done
  > When done with this frame, type C-x 5 0
  > (No files need saving)
  > When done with this frame, type C-x 5 0
  > 
  > Load-path shadows:
  > None found.
  > 
  > -- 
  > Óscar Fuentes
  > Desarrollo de Software





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#4144: marked as done (23.1.50; VC Annotate for bzr files broken)
  2009-08-14 19:52 ` bug#4144: 23.1.50; VC Annotate for bzr files broken =C3=93scar?= Fuentes
  2009-08-15  6:24   ` Dan Nicolaescu
@ 2009-12-06 20:30   ` Emacs bug Tracking System
  1 sibling, 0 replies; 4+ messages in thread
From: Emacs bug Tracking System @ 2009-12-06 20:30 UTC (permalink / raw)
  To: Chong Yidong

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

Your message dated Sun, 06 Dec 2009 15:24:28 -0500
with message-id <87638jc0lf.fsf@stupidchicken.com>
and subject line Re: bug#4144: 23.1.50; VC Annotate for bzr files broken
has caused the Emacs bug report #4144,
regarding 23.1.50; VC Annotate for bzr files broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)

-- 
4144: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4144
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6362 bytes --]

From: ofv@wanadoo.es (Óscar Fuentes)
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; VC Annotate for bzr files broken
Date: Fri, 14 Aug 2009 21:52:39 +0200
Message-ID: <87ab222mwo.fsf@telefonica.net>

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The Annotate view of bzr files doesn't show author and revision #
information. Seems that emacs does not understand the annotate output of
bzr.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/share/emacs/23.1.50/etc/DEBUG for instructions.

In GNU Emacs 23.1.50.3 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2009-07-31 on qcore
Windowing system distributor `The X.Org Foundation', version 11.0.60900000
configured using `configure  '--with-x-toolkit=lucid''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  show-paren-mode: t
  diff-auto-refine-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
<right> <right> <right> <backspace> <return> <tab> 
C-y C-x C-s C-x b l l v m - c <return> <backspace> 
C-x C-s C-x b <return> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> C-e <left> 
<left> <left> <left> <left> <left> c m a k e . C-x 
C-s C-x b C-g C-x b <return> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> e c h o SPC " r 
p u e <backspace> <backspace> <backspace> <backspace> 
r p <backspace> <backspace> p r u e b a " SPC > > C-x 
C-s M-x g n u s <return> <down> <return> d q <return> 
d q q y C-x b s t a t u <return> <down> g <down> <down> 
m m <up> <up> <down> C-u D y e s <return> <up> m <down> 
m <up> r y e s <return> M-x g n s <backspace> u s <return> 
<return> d q <down> <return> d q <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> <return> <return> <return> <return> 
<return> <return> q q y <help-echo> h C-x C-c <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
Destroying external MIME viewers
Saving file /home/oscar/.newsrc...
Wrote /home/oscar/.newsrc
Saving /home/oscar/.newsrc.eld...
Saving file /home/oscar/.newsrc.eld...
Wrote /home/oscar/.newsrc.eld
Saving /home/oscar/.newsrc.eld...done
When done with this frame, type C-x 5 0
(No files need saving)
When done with this frame, type C-x 5 0

Load-path shadows:
None found.

-- 
Óscar Fuentes
Desarrollo de Software

[-- Attachment #3: Type: message/rfc822, Size: 1892 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, 4144-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4144: 23.1.50; VC Annotate for bzr files broken
Date: Sun, 06 Dec 2009 15:24:28 -0500
Message-ID: <87638jc0lf.fsf@stupidchicken.com>

> The breakage is caused by commits with empty `committer' field (in
> this case coming from conversions from other VCS). This confuses the
> regexp used by vc-bzr-annotate-command for determining revision id,
> author and date.

Thanks.  I checked this change into CVS.

Also, as Dan pointed out, the Bzr backend shouldn't be hiding the author
annotation, so I put it back in.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#4144: 23.1.50; VC Annotate for bzr files broken
@ 2009-09-07  5:17 Óscar Fuentes
  0 siblings, 0 replies; 4+ messages in thread
From: Óscar Fuentes @ 2009-09-07  5:17 UTC (permalink / raw)
  To: 4144

The breakage is caused by commits with empty `committer' field (in this
case coming from conversions from other VCS). This confuses the regexp
used by vc-bzr-annotate-command for determining revision id, author and
date.

Some experimentation shows that this regexp works on the case of empty
committer field too:

*** /usr/local/share/emacs/23.1.50/lisp/vc-bzr.el.gz
--- /tmp/buffer-content-191724Q
***************
*** 547,553 ****
      ;; to allow saving space by sharing the text properties.
      (setq vc-bzr-annotation-table (make-hash-table :test 'equal))
      (goto-char (point-min))
!     (while (re-search-forward "^\\( *[0-9.]+ *\\) \\([^\n ]+\\) +\\([0-9]\\{8\\}\\) |"
                                nil t)
        (let* ((rev (match-string 1))
               (author (match-string 2))
--- 547,554 ----
      ;; to allow saving space by sharing the text properties.
      (setq vc-bzr-annotation-table (make-hash-table :test 'equal))
      (goto-char (point-min))
!     ;;; `author' field may be empty:
!     (while (re-search-forward "^\\( *[0-9.]+\\) *\\([^\n ]* *?\\) +\\([0-9]\\{8\\}\\) |"
                                nil t)
        (let* ((rev (match-string 1))
               (author (match-string 2))





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-12-06 20:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87638jc0lf.fsf@stupidchicken.com>
2009-08-14 19:52 ` bug#4144: 23.1.50; VC Annotate for bzr files broken =C3=93scar?= Fuentes
2009-08-15  6:24   ` Dan Nicolaescu
2009-12-06 20:30   ` bug#4144: marked as done (23.1.50; VC Annotate for bzr files broken) Emacs bug Tracking System
2009-09-07  5:17 bug#4144: 23.1.50; VC Annotate for bzr files broken Óscar Fuentes

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).