From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 7908@debbugs.gnu.org, tk@giga.or.at
Subject: bug#7908: png-1.5 fix for emacs-23.2 and HEAD
Date: Sat, 29 Jan 2011 16:29:10 -0500 [thread overview]
Message-ID: <87aaijtn4p.fsf@stupidchicken.com> (raw)
In-Reply-To: <83y663fng5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jan 2011 22:46:02 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Aha, I think it makes sense. Since DEF_IMGLIB_FN defines a return type
>> of int, whereas fn_png_set_longjmp_fn actually returns a (jmp_buf *), we
>> do indeed need to perform the extra cast. Well spotted. Does Emacs
>> compile properly with this change?
>
> Yes, it does.
Excellent. I've committed the corrected patch. Thanks very much for
helping fix this.
next prev parent reply other threads:[~2011-01-29 21:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:54 bug#7908: png-1.5 fix for emacs-23.2 and HEAD Thomas Klausner
2011-01-24 17:43 ` Eli Zaretskii
2011-01-24 21:59 ` Thomas Klausner
2011-01-25 3:49 ` Eli Zaretskii
2011-01-25 7:18 ` Thomas Klausner
2011-01-25 10:53 ` Eli Zaretskii
2011-01-25 11:29 ` Thomas Klausner
2011-01-25 20:57 ` Chong Yidong
2011-01-25 21:09 ` Chong Yidong
2011-01-25 21:56 ` Eli Zaretskii
2011-01-25 23:35 ` Chong Yidong
2011-01-29 13:54 ` Eli Zaretskii
2011-01-29 15:44 ` Chong Yidong
2011-01-29 16:16 ` Eli Zaretskii
2011-01-29 18:29 ` Chong Yidong
2011-01-29 19:02 ` Eli Zaretskii
2011-01-29 19:50 ` Eli Zaretskii
2011-01-29 20:33 ` Chong Yidong
2011-01-29 20:46 ` Eli Zaretskii
2011-01-29 21:29 ` Chong Yidong [this message]
2011-01-29 22:03 ` Andreas Schwab
2011-01-29 22:27 ` Chong Yidong
2011-01-30 0:00 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aaijtn4p.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=7908@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=tk@giga.or.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).