From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 24 Feb 2012 22:54:28 +0100 Message-ID: <87aa47rj6z.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <871uqz651u.fsf@gmx.de> <87pqd89lh4.fsf@gmail.com> <87mx8b3nvb.fsf@gmail.com> <87pqd6wnvv.fsf@gmail.com> <87d395y1w0.fsf@gmail.com> <87zkc8x04p.fsf@gmail.com> <87vcmwwvk7.fsf@gmail.com> <834nugtwqf.fsf@gnu.org> <87r4xkwhky.fsf@gmail.com> <83vcmws3bs.fsf@gnu.org> <87ehtkwaiz.fsf@gmail.com> <87wr7cgsm3.fsf@gmx.de> <8762eww77b.fsf@gmail.com> <83pqd4roav.fsf@gnu.org> <87haygx97t.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330120542 5988 80.91.229.3 (24 Feb 2012 21:55:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Feb 2012 21:55:42 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 24 22:55:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S1372-0003Wx-9V for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 22:55:36 +0100 Original-Received: from localhost ([::1]:41261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S136y-0004sK-Ac for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 16:55:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S136u-0004jh-N9 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 16:55:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S136t-0002Vf-9H for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 16:55:28 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S136t-0002VZ-3u for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 16:55:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S139O-0004eJ-2H for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2012 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.133012063717819 (code B ref 10489); Fri, 24 Feb 2012 21:58:02 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 24 Feb 2012 21:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:54636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S138f-0004dL-1p for submit@debbugs.gnu.org; Fri, 24 Feb 2012 16:57:17 -0500 Original-Received: from mail-wi0-f172.google.com ([209.85.212.172]:57449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S138b-0004d7-L2 for 10489@debbugs.gnu.org; Fri, 24 Feb 2012 16:57:14 -0500 Original-Received: by wibhm9 with SMTP id hm9so1750646wib.3 for <10489@debbugs.gnu.org>; Fri, 24 Feb 2012 13:54:32 -0800 (PST) Received-SPF: pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.216.134.5 as permitted sender) client-ip=10.216.134.5; Authentication-Results: mr.google.com; spf=pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.216.134.5 as permitted sender) smtp.mail=thierry.volpiatto@gmail.com; dkim=pass header.i=thierry.volpiatto@gmail.com Original-Received: from mr.google.com ([10.216.134.5]) by 10.216.134.5 with SMTP id r5mr2128719wei.39.1330120472248 (num_hops = 1); Fri, 24 Feb 2012 13:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=/7JSdWMo1hUv873Na9dN1u3fvtY7up0OVBZ5EZ+3sUY=; b=dt3ss1utUsS3fS9yk11cs2mR0GMyW/LdlmR4QS37IT0X/bZsm1Y84qAGxjpfU4dQMd LfvmYYQFXsJW626ayLJCDStN1QJnX10W8lTZehDXLNBJQvSPeqKUNVWkpl2BcuTAVRSW SOnRmvJaZ0hIXgALyyJXk3DZW+ZUAVPad90tA= Original-Received: by 10.216.134.5 with SMTP id r5mr1716115wei.39.1330120472191; Fri, 24 Feb 2012 13:54:32 -0800 (PST) Original-Received: from thierry-MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id s8sm6117921wiz.8.2012.02.24.13.54.30 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 13:54:31 -0800 (PST) In-Reply-To: <87haygx97t.fsf@gmx.de> (Michael Albinus's message of "Fri, 24 Feb 2012 21:33:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57198 Archived-At: Michael Albinus writes: > Eli Zaretskii writes: > >>> From: Thierry Volpiatto >>> Cc: Eli Zaretskii , 10489@debbugs.gnu.org >>> Date: Fri, 24 Feb 2012 17:02:16 +0100 >>> >>> (defun files-equal-p (file1 file2) >>> "Return non-nil if FILE1 and FILE2 name the same file." >>> (let ((handler (or (find-file-name-handler file1 'files-equal-p) >>> (find-file-name-handler file2 'files-equal-p)))) >>> (if handler >>> (funcall handler 'files-equal-p file1 file2) >> >> If FILE1 and FILE2 have different 'files-equal-p handlers, which one >> of them, if any, should be invoked here? > > The one for FILE1. > >> IOW, shouldn't we invoke a file handler only if it can handle _both_ >> files? Also, if each file has a different handler, doesn't that in >> itself already mean the files are not equal? > > We shouldn't add too much to file name handler optimization here. The > handler will know what to do. > > Likely, there won't be different handlers. It's always > `tramp-file-name-handler', which calls the respective sub-handlers. Now we have an error until you write handlers: tramp-file-name-for-operation: unknown file I/O primitive: file-subdir-of-p This happen when copying with sudo method. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997