From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12456: 24.2.50; Completion in `Info-goto-node' (cross-manual jump) Date: Tue, 18 Sep 2012 23:03:21 +0300 Organization: JURTA Message-ID: <87a9wn85fa.fsf@mail.jurta.org> References: <83sjaf26jt.fsf@gnu.org> <83boh31lrj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1347998927 17018 80.91.229.3 (18 Sep 2012 20:08:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2012 20:08:47 +0000 (UTC) Cc: 12456@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 18 22:08:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TE46C-0002kF-RJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2012 22:08:48 +0200 Original-Received: from localhost ([::1]:53375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE468-00047b-Iv for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2012 16:08:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE465-00046w-NO for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2012 16:08:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE464-0006rU-Jj for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2012 16:08:41 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE464-0006rQ-G4 for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2012 16:08:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TE47N-0000rz-Lz for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2012 16:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Sep 2012 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12456-submit@debbugs.gnu.org id=B12456.13479989883294 (code B ref 12456); Tue, 18 Sep 2012 20:10:01 +0000 Original-Received: (at 12456) by debbugs.gnu.org; 18 Sep 2012 20:09:48 +0000 Original-Received: from localhost ([127.0.0.1]:42271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TE47A-0000r5-A6 for submit@debbugs.gnu.org; Tue, 18 Sep 2012 16:09:48 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:59320 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TE477-0000qw-Fq for 12456@debbugs.gnu.org; Tue, 18 Sep 2012 16:09:46 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D8BC6451CC45; Tue, 18 Sep 2012 13:08:21 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 18 Sep 2012 12:57:22 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64576 Archived-At: >> * "(elisp)" completes to all nodes in the elisp manual. > > Yes, that's the part that's not yet implemented. Patch welcome, This can be implemented by this patch. The remaining problem is that it's too slow because it doesn't cache completions of non-current manuals. Perhaps `Info-build-node-completions' should use `Info-toc-nodes' that caches node names from all visited manuals. === modified file 'lisp/info.el' --- lisp/info.el 2012-09-13 22:01:45 +0000 +++ lisp/info.el 2012-09-18 20:02:43 +0000 @@ -1778,12 +1778,23 @@ (defun Info-read-node-name-1 (string pre (substring string 1) predicate code)) - ;; If a file name was given, then any node is fair game. - ((string-match "\\`(" string) - (cond - ((eq code nil) string) - ((eq code t) nil) - (t t))) + ;; If a file name was given, complete nodes in the file. + ((string-match "\\`([^)]+)" string) + (let ((file (match-string 0 string)) + (node (substring string (match-end 0)))) + (completion-table-with-context + file + (apply-partially + (lambda (string pred action) + (complete-with-action + action + (with-temp-buffer + (Info-mode) + (Info-goto-node (concat file "Top")) + (Info-build-node-completions) + Info-current-file-completions) + string pred))) + node predicate code))) ;; Otherwise use Info-read-node-completion-table. (t (complete-with-action code Info-read-node-completion-table string predicate))))