unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Yuriy Vostrikov <delamonpansie@gmail.com>, 6137-done@debbugs.gnu.org
Subject: bug#6137: [Yuriy Vostrikov] emacs, vc-git
Date: Fri, 30 Nov 2012 15:43:38 +0800	[thread overview]
Message-ID: <87a9tzsfh1.fsf@gnu.org> (raw)
In-Reply-To: <jwvr5lnjvmk.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 07 May 2010 16:41:15 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> [ I do not use Git enough to be sure if his patch is the right way to
>   fix it.  It does look OK, tho maybe the right (but harder) place to
>   fix it is in Tramp.  Can someone take a look and install it?  --Stef  ]
>
> Hello.
> You are last commiter of vc-git.el so i'm writing to you.
>
> It's probably a good idea to forcefully disable pager then calling git
> command from vc-git.el.  If buffer is tramp controlled then git will
> be run on remote host by tramp magic. In this particular case git
> stdout will be connected to pty instead of pipe and default git
> behavior to call $PAGER in this case.  Which is effectively makes
> vc-git broken on tramp controlled buffers.  Patch is attached.

Since no one's done anything about this, and the fix looks OK, I've
committed it to trunk.





      parent reply	other threads:[~2012-11-30  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwvr5lnjvmk.fsf-monnier+emacs@gnu.org>
2010-05-07 21:39 ` bug#6137: [Yuriy Vostrikov] emacs, vc-git Glenn Morris
2012-11-30  7:43 ` Chong Yidong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9tzsfh1.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=6137-done@debbugs.gnu.org \
    --cc=delamonpansie@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).