From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed Date: Sat, 15 Dec 2012 12:59:00 +0200 Organization: JURTA Message-ID: <87a9tf1szv.fsf@mail.jurta.org> References: <87fw3bpqir.fsf@mail.jurta.org> <8738zasw5w.fsf@mail.jurta.org> <87obhxbgdw.fsf@mail.jurta.org> <50CAFEBC.6000208@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1355569807 6390 80.91.229.3 (15 Dec 2012 11:10:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Dec 2012 11:10:07 +0000 (UTC) Cc: Leo , 13152@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 15 12:10:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TjpdJ-0006Si-RC for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Dec 2012 12:10:17 +0100 Original-Received: from localhost ([::1]:56578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjpd6-000302-CM for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Dec 2012 06:10:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjpd2-0002x7-E7 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:10:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjpd1-0003Hr-DX for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:10:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjpd1-0003Hl-A3 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:09:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tjpe1-0000bp-VD for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 06:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Dec 2012 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13152 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13152-submit@debbugs.gnu.org id=B13152.13555698392309 (code B ref 13152); Sat, 15 Dec 2012 11:11:01 +0000 Original-Received: (at 13152) by debbugs.gnu.org; 15 Dec 2012 11:10:39 +0000 Original-Received: from localhost ([127.0.0.1]:43369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjpde-0000bB-DG for submit@debbugs.gnu.org; Sat, 15 Dec 2012 06:10:39 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:50437 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjpdb-0000ay-N7 for 13152@debbugs.gnu.org; Sat, 15 Dec 2012 06:10:36 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7C9F7451CD5D; Sat, 15 Dec 2012 03:09:31 -0800 (PST) In-Reply-To: <50CAFEBC.6000208@gmx.at> (martin rudalics's message of "Fri, 14 Dec 2012 11:26:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68541 Archived-At: > But FUNCTION "should not manipulate files, just read input > \(an argument or confirmation)." so I don't see why this matters. I agree it shouldn't matter in which buffer FUNCTION is called. The problem is caused by the flawed design of dired-x where `dired-guess-default' doesn't propagate the value of `files' to the evaluated expressions in `dired-guess-shell-alist-default'. Also note how `dired-guess-shell-alist-default' is forced to use the dynamically bound variable `file'. The proper fix would be to redesign `dired-guess-shell-alist-default' to funcall lambdas with one arg `files' instead of using `eval'. So instead of (setq dired-guess-shell-alist-user '(("." (let ((files (dired-get-marked-files t current-prefix-arg))) (let (dired-guess-shell-alist-user) (dired-guess-default files)))))) Leo would be able to use (setq dired-guess-shell-alist-user '(("." (lambda (files) (let (dired-guess-shell-alist-user) (dired-guess-default files)))))) This could help to move useful features from dired-x.el to dired-aux.el.