From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nathan Trapuzzano Newsgroups: gmane.emacs.bugs Subject: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Date: Tue, 05 Nov 2013 21:19:06 -0500 Message-ID: <87a9himfvp.fsf@nbtrap.com> References: <87k3gmmvk9.fsf@nbtrap.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383704656 19785 80.91.229.3 (6 Nov 2013 02:24:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Nov 2013 02:24:16 +0000 (UTC) Cc: 15814@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 06 03:24:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vdsn5-0003il-W1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2013 03:24:20 +0100 Original-Received: from localhost ([::1]:59483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdsn5-0006W8-5Y for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Nov 2013 21:24:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdsmv-0006RP-FF for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 21:24:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdsmp-0007e2-7g for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 21:24:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdsiz-0006pE-BT for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 21:20:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vdsiy-00058Q-D6 for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 21:20:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nathan Trapuzzano Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2013 02:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15814-submit@debbugs.gnu.org id=B15814.138370436119672 (code B ref 15814); Wed, 06 Nov 2013 02:20:04 +0000 Original-Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 02:19:21 +0000 Original-Received: from localhost ([127.0.0.1]:36409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdsiG-00057E-QL for submit@debbugs.gnu.org; Tue, 05 Nov 2013 21:19:21 -0500 Original-Received: from [74.220.205.131] (port=50301 helo=alt-proxy3.mail.unifiedlayer.com) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VdsiE-000575-3o for 15814@debbugs.gnu.org; Tue, 05 Nov 2013 21:19:19 -0500 Original-Received: (qmail 5488 invoked by uid 0); 6 Nov 2013 02:19:16 -0000 Original-Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy19-pub.mail.unifiedlayer.com with SMTP; 6 Nov 2013 02:19:16 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=GdTty4YtmsD7oLAGs7/Heh5CDylutb4HY4ch9vYNQ1M=; b=ocHl9P1ZZR3jdkvqIRfFkbu4xwoCGEjwE9wCcWdiw5EsMHMve4ZYLlBXP/XfnbMx2ln5n4nXkqPJ3uMwO3TmLiKKkgyIovm15BkKSVtSLegEzcqpAKWPMQBSRLh2qSfi; Original-Received: from [50.90.253.209] (port=50322 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VdsiB-0005EN-Iv; Tue, 05 Nov 2013 19:19:16 -0700 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Nov 2013 19:46:45 -0500") User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80054 Archived-At: Stefan Monnier writes: > Good idea. Could you try and use macroexp--warn-and-return instead, so > we get a file&line location when byte-compiling? I'm not certain what you mean here. You seem to agree that this is an error, but `macroexp--warn-and-return' doesn't signal an error--it just prints a warning. If we do something like this: (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" (car bindings)))) (macroexp--warn-and-return msg `(error "%s" ,msg))) we'll get a warning at compile time and an error at run time. Is this what you have in mind? Shouldn't we signal the error as early as possible? Perhaps there is some Emacs convention that I'm not aware of in this regard. > BTW, the same holds for the "let" sanity checks you added to cconv > (which should probably be moved to macroexp, now that I think about it, > so we can remove them from bytecomp.el). I don't understand this either. By "moved to macroexp", do you just mean that the sanity checks should be performed using macroexp--warn-and-return in the manner given above? Sorry for my confusion. Nathan