From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#17815: 24.4.50; (process-file) erroneously raises its buffer when running with TRAMP Date: Sun, 22 Jun 2014 15:46:59 +0200 Message-ID: <87a9953vl8.fsf@gmx.de> References: <87r42km287.fsf@secretsauce.net> <87wqccasm9.fsf@gmx.de> <87r42jbsg7.fsf@gmx.de> <87ha3d47ka.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403444995 20939 80.91.229.3 (22 Jun 2014 13:49:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Jun 2014 13:49:55 +0000 (UTC) Cc: Dima Kogan , 17815@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 22 15:49:47 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wyi9T-00065A-Is for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jun 2014 15:49:47 +0200 Original-Received: from localhost ([::1]:49056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wyi9T-0005kN-8e for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jun 2014 09:49:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wyi7s-0003io-J0 for bug-gnu-emacs@gnu.org; Sun, 22 Jun 2014 09:48:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wyi7m-0007uG-Mq for bug-gnu-emacs@gnu.org; Sun, 22 Jun 2014 09:48:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wyi7m-0007uA-Kk for bug-gnu-emacs@gnu.org; Sun, 22 Jun 2014 09:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wyi7l-0000VG-UF for bug-gnu-emacs@gnu.org; Sun, 22 Jun 2014 09:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jun 2014 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17815-submit@debbugs.gnu.org id=B17815.14034448411882 (code B ref 17815); Sun, 22 Jun 2014 13:48:01 +0000 Original-Received: (at 17815) by debbugs.gnu.org; 22 Jun 2014 13:47:21 +0000 Original-Received: from localhost ([127.0.0.1]:56740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wyi76-0000UH-Gt for submit@debbugs.gnu.org; Sun, 22 Jun 2014 09:47:20 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:52716) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wyi73-0000Tw-4z for 17815@debbugs.gnu.org; Sun, 22 Jun 2014 09:47:18 -0400 Original-Received: from detlef.gmx.de ([93.209.76.111]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MgHHO-1XIxyv2qhi-00NkUw; Sun, 22 Jun 2014 15:47:08 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 22 Jun 2014 08:55:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-Provags-ID: V03:K0:MJPItQqWOkzAps76YAqXCWY+dCCKOtOIm1kqnztzvCR7RmcHX2k lras8UO0wI1dTg6IUegetZHy4OfFP4P3bKszRtJ5g/22pprXFowDKp0pvN1OChR0TzjrDil zQEvNM1JgrKG6eOorbjVf3gORNLNZsgRidvK3CyXFqGCZMsSrrtIHtgOKjV9CNNYsXtaQR2 HdCEm74aohiaNTG6c9cOw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90666 Archived-At: Stefan Monnier writes: >> Well, all handlers I could factor out for several backends, live in >> tramp.el as `tramp-handle-...'. `tramp-adb-handle-process-file' and >> `tramp-sh-handle-process-file' contain subtle differences, it will be >> harder to refactor them. > > Those functions are almost 100 lines long and yet the diff between the > two is only the little thing below. Right, that's why I wrote about "subtle" differences. > Clearly, there's room for a good refactoring. Maybe you can't replace > them with a single function, but you can create a third function that > holds most of the code. Sure. But lately I was plagued with recursive loading of Tramp packages, so I'm a little bit conservative in moving code between the different files. Whenever it is possible to refactor code out I'll do. *-process-file is on the list, but I cannot promise to do it immediately. One idea is to generalize `tramp-send-command' and friends, for most of the handlers this is the major difference between the different backends. Other handlers but *-process-file would profit from this as well. > Stefan Best regards, Michael.