From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Date: Fri, 11 Jul 2014 16:57:40 +0200 Message-ID: <87a98g54ez.fsf@gmx.de> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> <87k37k5an5.fsf@gmx.de> <83tx6o9enr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1405090771 23443 80.91.229.3 (11 Jul 2014 14:59:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Jul 2014 14:59:31 +0000 (UTC) Cc: schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 11 16:59:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X5cIB-0004yv-JQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Jul 2014 16:59:19 +0200 Original-Received: from localhost ([::1]:45360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cIB-0006b8-0o for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Jul 2014 10:59:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cI1-0006Zb-G5 for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 10:59:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5cHu-0005Qe-VB for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 10:59:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cHu-0005QW-Rv for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X5cHu-0002FS-50 for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050906898555 (code B ref 17839); Fri, 11 Jul 2014 14:59:02 +0000 Original-Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 14:58:09 +0000 Original-Received: from localhost ([127.0.0.1]:53594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5cGz-0002Dp-6j for submit@debbugs.gnu.org; Fri, 11 Jul 2014 10:58:09 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:57363) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5cGs-0002DA-K9 for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 10:58:02 -0400 Original-Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LqE5k-1WRrfm2G5g-00dkoi; Fri, 11 Jul 2014 16:57:46 +0200 In-Reply-To: <83tx6o9enr.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jul 2014 17:02:48 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-Provags-ID: V03:K0:5lPh9M/g4xYu0AVxrsq3yVIQm5yVkvv4E4a8itubqwrXXnPYCDJ 5dHx2NIEpEk2L2qT8StuUDUA2BfBdoskNZSJO4KtyTyPpy5RFjhXQETYT3NxpmMJn91Z9qE 813mqY367R40JQi06n0AsJmrcrlmjbHor85dfJKfOvdxYqYHudcwOa3b62gD0xQnjCB94Kf kMAkHJll0R0frfLJsrf1A== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91447 Archived-At: Eli Zaretskii writes: > The result is not 100% satisfactory, as one needs to press RET twice > to finish the input, and it looks like some garbage is left in the > input buffer, since the following (normal) input gets something > strange. A workaround is to press C-z, which produces EOF, instead of > RET, when password entry is finished. Maybe because just "\n" is sent by fprintf()? In the Windows case, "\r\n" might be the better choice? And maybe we must handle the case, that RET sends 2 characters, which must be handled by a double call of getchar()? > I also needed a change in minibuf.c to end the reading loop on CR, not > just a newline. If this is bad news for Posix platforms, we can make > that code conditional on Windows. That's OK, I've just tested. When I've read the code of read_minibuf_noninteractive for the first time, I've seen that just CR was used for finishing input, and I've thought that nobody ever used this for MS Windows. This is one of the reasons I was somehow Windows agnostic during my work. Best regards, Michael.