bug#18897: [PATCH] using advice-add

[Eric Abrahamsen <eric@ericabrahamsen.net>]

[-- Attachment #1: Type: text/plain, Size: 63 bytes --]

Here's a patch that replaces the defalias with an advice-add.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Print-EIEIO-objects-correctly-when-edebugging.patch --]
[-- Type: text/x-diff, Size: 2654 bytes --]

From 6d80c0f46ca471d17415f6f1b5f8881c27f330b6 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Wed, 29 Oct 2014 19:24:07 -0700
Subject: [PATCH] Print EIEIO objects correctly when edebugging

* lisp/emacs-lisp/eieio.el (eieio-edebug-prin1-to-string): Modify
  function for use as advice.
  (edebug-setup-hook): Add `eieio-edebug-prin1-to-string' as advice on
  `edebug-prin1-to-string'.

This will prevent objects containing large data structures from
hammering Emacs during pretty-printing.  eieio.el came with controls
for printing EIEIO objects during edebugging sessions, but the
controls weren't hooked up all the way.
---
 lisp/emacs-lisp/eieio.el | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/lisp/emacs-lisp/eieio.el b/lisp/emacs-lisp/eieio.el
index d7c60dc..543d640 100644
--- a/lisp/emacs-lisp/eieio.el
+++ b/lisp/emacs-lisp/eieio.el
@@ -853,17 +853,19 @@ of `eq'."
 
 ;;; Interfacing with edebug
 ;;
-(defun eieio-edebug-prin1-to-string (object &optional noescape)
+(defun eieio-edebug-prin1-to-string (print-function object &optional noescape)
   "Display EIEIO OBJECT in fancy format.
-Overrides the edebug default.
-Optional argument NOESCAPE is passed to `prin1-to-string' when appropriate."
+
+Used as advice around `edebug-prin1-to-string', held in the
+variable PRINT-FUNCTION.  Optional argument NOESCAPE is passed to
+`prin1-to-string' when appropriate."
   (cond ((class-p object) (eieio-class-name object))
 	((eieio-object-p object) (object-print object))
 	((and (listp object) (or (class-p (car object))
 				 (eieio-object-p (car object))))
 	 (concat "(" (mapconcat #'eieio-edebug-prin1-to-string object " ")
                  ")"))
-	(t (prin1-to-string object noescape))))
+	(t (funcall print-function object noescape))))
 
 (add-hook 'edebug-setup-hook
 	  (lambda ()
@@ -887,14 +889,8 @@ Optional argument NOESCAPE is passed to `prin1-to-string' when appropriate."
 	    (def-edebug-spec class-constructor form)
 	    (def-edebug-spec generic-p form)
 	    (def-edebug-spec with-slots (list list def-body))
-	    ;; I suspect this isn't the best way to do this, but when
-	    ;; cust-print was used on my system all my objects
-	    ;; appeared as "#1 =" which was not useful.  This allows
-	    ;; edebug to print my objects in the nice way they were
-	    ;; meant to with `object-print' and `class-name'
-	    ;; (defalias 'edebug-prin1-to-string 'eieio-edebug-prin1-to-string)
-	    )
-	  )
+	    (advice-add #'edebug-prin1-to-string
+			:around #'eieio-edebug-prin1-to-string)))
 
 \f
 ;;; Start of automatically extracted autoloads.
-- 
2.1.2