From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree Date: Wed, 19 Nov 2014 21:14:42 +0100 Message-ID: <87a93nrlql.fsf@rosalinde.fritz.box> References: <87lhn7s522.fsf@rosalinde.fritz.box> <83lhn789tq.fsf@gnu.org> <87h9xvruan.fsf@rosalinde.fritz.box> <83tx1v6mur.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416428133 21924 80.91.229.3 (19 Nov 2014 20:15:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2014 20:15:33 +0000 (UTC) Cc: paul@tilk.co, 19102@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 19 21:15:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrBev-00088d-Dr for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 21:15:25 +0100 Original-Received: from localhost ([::1]:60510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrBeu-00006E-Uk for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 15:15:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrBeg-0008IF-Iu for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:15:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrBea-0002x8-1Z for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:15:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrBeZ-0002wH-Vc for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrBeZ-0003d9-FU for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 15:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Nov 2014 20:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19102-submit@debbugs.gnu.org id=B19102.141642809013920 (code B ref 19102); Wed, 19 Nov 2014 20:15:03 +0000 Original-Received: (at 19102) by debbugs.gnu.org; 19 Nov 2014 20:14:50 +0000 Original-Received: from localhost ([127.0.0.1]:38684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrBeL-0003cS-Jt for submit@debbugs.gnu.org; Wed, 19 Nov 2014 15:14:49 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:55003) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrBeI-0003cI-FL for 19102@debbugs.gnu.org; Wed, 19 Nov 2014 15:14:47 -0500 Original-Received: from rosalinde.fritz.box ([89.245.64.17]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M1BMy-1Y6N7S3Wky-00tAHk; Wed, 19 Nov 2014 21:14:42 +0100 In-Reply-To: <83tx1v6mur.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 19 Nov 2014 20:56:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:L9BgNRojbSHZtiJcwYQ2lEoTmBCvxAc6wdaJY1OtgB2V3IyY8Ph +L3wc9pRcTfLQ7cwg/J5rAUkIcZYfY273SssEc8ipKtmngstyZq81s04ZOROCYOsfwXzNhk HujcnV0jnAq6KpbJQJSNAngf/sx36CigAh/hE3J8i99PmLFUal1cazBjb4qaSc8Pc8wSXtD /wRu/eY74r0B1yaPz+kWw== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96274 On Wed, 19 Nov 2014 20:56:12 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: paul@tilk.co, 19102@debbugs.gnu.org >> Date: Wed, 19 Nov 2014 18:09:52 +0100 >> >> On Wed, 19 Nov 2014 17:54:41 +0200 Eli Zaretskii wrote: >> > Thanks. Can you explain why the problem happened in the first place? >> >> The error occurs when the sexp `(= (char-after) ?\n)' in >> outline-move-subtree-down is evaluated at eob. > > Wouldn't using eolp instead of the comparison solve that problem more > easily? Well, that eliminates the wrong-type-argument error in the current code, but it instead signals "End of buffer" and still fails to move the subtree in the cases I listed. But using eolp in place of the comparison in my patch is fine, and cleaner, so thanks. Do you see any other problems with the patch or more room for improvement? Steve Berman