From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...) Date: Fri, 23 Jan 2015 15:27:19 +0000 Message-ID: <87a919o6ug.fsf@violet.siamics.net> References: <87r40yftes.fsf@violet.siamics.net> <87ha1ot8kp.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1422026899 9701 80.91.229.3 (23 Jan 2015 15:28:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Jan 2015 15:28:19 +0000 (UTC) To: 18175-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 23 16:28:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YEg9e-0008D3-0q for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jan 2015 16:28:14 +0100 Original-Received: from localhost ([::1]:59931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEg9d-0002Qe-HW for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jan 2015 10:28:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEg9Y-0002LY-3D for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 10:28:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEg9U-0003Xl-MO for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 10:28:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEg9T-0003V2-Tz for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 10:28:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YEg9T-0003cy-Bi for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 10:28:03 -0500 Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jan 2015 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18175-done@debbugs.gnu.org id=D18175.142202685613901 (code D ref 18175); Fri, 23 Jan 2015 15:28:02 +0000 Original-Received: (at 18175-done) by debbugs.gnu.org; 23 Jan 2015 15:27:36 +0000 Original-Received: from localhost ([127.0.0.1]:54438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEg91-0003c8-Lx for submit@debbugs.gnu.org; Fri, 23 Jan 2015 10:27:36 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:50669) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEg8x-0003bv-OX for 18175-done@debbugs.gnu.org; Fri, 23 Jan 2015 10:27:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=bS8o/BoT72tldfuG5c6CZH/HLTghGKfHPenx4zdrjxE=; b=apKTVvXNd67cRR6h5xmz0csCqF2MZCDH1i77vnlKk1rugiNOjX6YcoSbPEZPe7yZDa6HLQiNLjHQEYdaBZr7IvWRye+rX/R7VXsqAy5p48nTTdjeWNWERPgW1Cq6birxlket3FcKZ73Ruw4BIemqBstDoI6WOKGTAVgz9mJtsyk=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YEg8u-0002ce-9l for 18175-done@debbugs.gnu.org; Fri, 23 Jan 2015 15:27:28 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YEg8m-0002oX-D8 for 18175-done@debbugs.gnu.org; Fri, 23 Jan 2015 22:27:20 +0700 Mail-Followup-To: 18175@debbugs.gnu.org In-Reply-To: (Stefan Monnier's message of "Thu, 07 Aug 2014 15:29:03 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98630 Archived-At: Version: 25.1 >>>>> Stefan Monnier writes: [=E2=80=A6] >> However, I believe that the last two hunks of the one another >> variant of the diff (MIMEd) actually make the intent to return the >> reverse of the list returned by find-file-noselect /clearer,/ =E2=80=93 >> although at the expense of adding one extra LoC in each case. > Agreed, and neither relies on the return value of `mapc', so those > two hunks are indeed good. Please install them. Done; closing. commit 3e824b05af3a75768a61001fad68e2340af810eb CommitDate: 2015-01-17 19:33:08 +0000 Avoid mapcar in two cases in files.el. =20=20=20=20 * lisp/files.el (find-file-other-window, find-file-other-frame): Use mapc instead of mapcar. =20=20=20=20 Fixes: debbugs:18175 --=20 FSF associate member #7257 np. Chemical Wedding =E2=80=93 Bruce Dickinson = 230E 334A