From: Ivan Shmakov <ivan@siamics.net>
To: 19865@debbugs.gnu.org
Subject: bug#19865: tar-untar-buffer: should honor default-directory
Date: Sat, 14 Feb 2015 11:31:12 +0000 [thread overview]
Message-ID: <87a90gd91b.fsf@violet.siamics.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Package: emacs
Severity: minor
Tags: patch
As currently implemented (tested on 7eb2077f9dd1, 2015-02-06
15:01:12 UTC), tar-untar-buffer uses the default-directory value
for the “data” buffer (see tar-data-buffer), instead of the
(arguably much less obscure) one for the tar-mode buffer itself
(which could easily be changed by the user via M-x cd.)
A possible fix is to remember the default-directory value in the
same ‘let’ form used to do so for tar-parse-info, along the
lines of the patch MIMEd.
--
FSF associate member #7257 np. A World Behind the World — Jami Sieber
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 864 bytes --]
--- a/lisp/tar-mode.el
+++ b/lisp/tar-mode.el
@@ -531,6 +542,7 @@ defun tar-untar-buffer ()
(interactive)
;; FIXME: make it work even if we're not in tar-mode.
- (let ((descriptors tar-parse-info)) ;Read the var in its buffer.
+ (let ((descriptors tar-parse-info) ; Read the var in its buffer.
+ (dest-dir default-directory))
(with-current-buffer
(if (tar-data-swapped-p) tar-data-buffer (current-buffer))
(set-buffer-multibyte nil) ;Hopefully, a no-op.
@@ -544,5 +564,6 @@ defun tar-untar-buffer ()
(dir (if (eq (tar-header-link-type descriptor) 5)
name
(file-name-directory name)))
+ (default-directory dest-dir)
(start (tar-header-data-start descriptor))
(end (+ start (tar-header-size descriptor))))
next reply other threads:[~2015-02-14 11:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 11:31 Ivan Shmakov [this message]
2015-02-14 12:16 ` bug#19865: tar-untar-buffer: should honor default-directory Eli Zaretskii
2015-02-14 12:27 ` Ivan Shmakov
2015-02-14 12:40 ` Eli Zaretskii
2015-02-14 12:47 ` Ivan Shmakov
2015-02-14 13:22 ` Eli Zaretskii
2015-02-14 13:34 ` Ivan Shmakov
2015-02-14 14:56 ` Eli Zaretskii
2015-02-14 15:16 ` Ivan Shmakov
2015-02-14 14:49 ` Stefan Monnier
2015-02-14 15:01 ` Eli Zaretskii
2015-02-16 1:43 ` Stefan Monnier
2015-02-16 15:43 ` Eli Zaretskii
2015-02-16 19:34 ` Stefan Monnier
2015-02-16 19:49 ` Eli Zaretskii
2015-02-16 23:40 ` Stefan Monnier
2015-02-17 3:37 ` Eli Zaretskii
2015-02-18 3:38 ` Stefan Monnier
2015-02-17 17:03 ` Wolfgang Jenkner
2015-02-17 18:02 ` Eli Zaretskii
2015-02-17 5:25 ` Ivan Shmakov
2015-02-17 15:46 ` Eli Zaretskii
2015-02-17 18:05 ` Ivan Shmakov
2015-02-14 15:07 ` Ivan Shmakov
2015-02-14 16:27 ` Ivan Shmakov
2015-02-16 1:48 ` Stefan Monnier
2015-02-16 5:24 ` Ivan Shmakov
2015-02-16 7:45 ` Stefan Monnier
2015-02-16 8:55 ` Ivan Shmakov
2015-02-16 14:58 ` Stefan Monnier
2016-02-23 11:04 ` Lars Ingebrigtsen
2019-06-25 17:55 ` Lars Ingebrigtsen
2015-02-14 15:57 ` Ivan Shmakov
2015-02-14 16:56 ` Eli Zaretskii
2015-02-14 17:32 ` Ivan Shmakov
2015-02-14 17:44 ` Eli Zaretskii
2015-02-14 18:12 ` Ivan Shmakov
2015-02-14 18:37 ` Eli Zaretskii
2015-02-14 19:12 ` Ivan Shmakov
2015-02-14 19:28 ` Eli Zaretskii
2015-02-14 19:42 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a90gd91b.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19865@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).