From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Date: Tue, 15 Sep 2015 07:53:34 +0200 Message-ID: <87a8sout29.fsf@gnu.org> References: <87k2s15sfd.fsf@gnu.org> <83oahc7vxr.fsf@gnu.org> <87lhcgvr1t.fsf@gmx.de> <87r3m4hrfq.fsf@gmx.de> <83fv2jbrkm.fsf@gnu.org> <87zj0rh5lb.fsf@gmx.de> <87h9myt96l.fsf@gmx.de> <87zj0pild7.fsf@gnu.org> <83oah5a35p.fsf@gnu.org> <87vbbdih3w.fsf@gnu.org> <87r3m1igdf.fsf@gnu.org> <837fnt9lup.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442296461 20460 80.91.229.3 (15 Sep 2015 05:54:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 05:54:21 +0000 (UTC) Cc: michael.albinus@gmx.de, 21432@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 15 07:54:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbjBy-0006wJ-LC for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 07:54:10 +0200 Original-Received: from localhost ([::1]:45151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbjBy-0004Dz-3t for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 01:54:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbjBu-0004Cv-Ur for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 01:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbjBq-0005gu-Pz for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 01:54:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbjBq-0005gm-M6 for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 01:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbjBq-0006MB-Cj for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 01:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2015 05:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21432-submit@debbugs.gnu.org id=B21432.144229641924351 (code B ref 21432); Tue, 15 Sep 2015 05:54:02 +0000 Original-Received: (at 21432) by debbugs.gnu.org; 15 Sep 2015 05:53:39 +0000 Original-Received: from localhost ([127.0.0.1]:60788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbjBS-0006Kh-El for submit@debbugs.gnu.org; Tue, 15 Sep 2015 01:53:38 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:57777) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbjBP-0006KY-Px for 21432@debbugs.gnu.org; Tue, 15 Sep 2015 01:53:36 -0400 Original-Received: from thinkpad-t440p (dhcp23.uni-koblenz.de [141.26.71.23]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 0CE441A8332; Tue, 15 Sep 2015 07:53:34 +0200 (CEST) In-Reply-To: <837fnt9lup.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Sep 2015 16:22:38 +0300") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106564 Archived-At: Eli Zaretskii writes: >> Done, however the descriptors still don't become invalid when >> deleting the parent directory of the watched file or directory. I >> guess, that's a problem in the inotify and TRAMP implementations >> then. > > No, I think it's a problem with our mental model of what happens. The > file notifications use the Emacs event loop, and Emacs won't check for > events until it's idle. So calling file-notify-valid-p as part of the > test ends up doing that _before_ the directory deletion notification > is read by Emacs and invalidates the watch. Yes, you are right. Michael already fixed the tests by waiting for the file notifications before calling `file-notify-valid-p' and then we get the expected results (well, not yet with remote files). Bye, Tassilo