From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Date: Sun, 03 Jul 2016 10:37:29 +0100 Message-ID: <87a8hzkqp2.fsf@russet.org.uk> References: <83h9cavdgj.fsf@gnu.org> <87poqyy2tc.fsf@metalevel.at> <87vb0qqrkz.fsf@russet.org.uk> <87h9c9zx75.fsf@metalevel.at> <834m89vmyv.fsf@gnu.org> <878txlsbdb.fsf@russet.org.uk> <87furtccdv.fsf@metalevel.at> <877fd5q9te.fsf@russet.org.uk> <83bn2gtruk.fsf@gnu.org> <87k2h37pvb.fsf@russet.org.uk> <87zipz223y.fsf@metalevel.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467538709 15463 80.91.229.3 (3 Jul 2016 09:38:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2016 09:38:29 +0000 (UTC) Cc: 23871@debbugs.gnu.org To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 03 11:38:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJdqw-0005S5-Ci for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 11:38:14 +0200 Original-Received: from localhost ([::1]:41863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdqu-0000fi-PS for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 05:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdqn-0000fb-JS for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJdqk-0006cB-8j for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdqk-0006c1-5U for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJdqj-0007Jt-V9 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2016 09:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23871-submit@debbugs.gnu.org id=B23871.146753865828106 (code B ref 23871); Sun, 03 Jul 2016 09:38:01 +0000 Original-Received: (at 23871) by debbugs.gnu.org; 3 Jul 2016 09:37:38 +0000 Original-Received: from localhost ([127.0.0.1]:35126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJdqM-0007JG-7d for submit@debbugs.gnu.org; Sun, 03 Jul 2016 05:37:38 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:36812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJdqK-0007J0-GJ for 23871@debbugs.gnu.org; Sun, 03 Jul 2016 05:37:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=3pvvnuV049kVBzNUpikjsW+iJs/Kgr1hIP82tDZnA6s=; b=hG34QCXQmk0k9hhau1SVOYJZNw A2OLs+CeEK7aGBBfaKFlk78+iXfPaj1s98mUJzeBcwhfx16Rueg53t8K7BCEUInmZbyhCG/hgYBDL 55NUqgR4QZ/5HcONY7AtdHGywybCCQ8Plydi3c/4Fch2ZgPrdx0YmbPOZoIlW4SZa7+u5nTqLq20X ghfb20InbEJPpYte4texCpy4hwdularAQZvxbTHhd5cbNRMaglSY7MQ+6BFRMe12Rdo03wcu0t5y8 1c1ZBlCfhTnwurJFPecFMDUrEvzYNhAzRUES60xfG9iijWg/F7oXIPAhQNb0I3VDxeb3wtWAXbu0X ZR3+Yrqw==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:54394 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bJdqE-001crm-4r; Sun, 03 Jul 2016 10:37:30 +0100 In-Reply-To: <87zipz223y.fsf@metalevel.at> (Markus Triska's message of "Sat, 02 Jul 2016 22:53:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120324 Archived-At: Markus Triska writes: > Hi Phillip, > > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> I believe the following patch addresses the issue. > > This patch causes a regression with the original case I posted in this > report (#23871): > > Without your patch, after undo, point is *either* > > (1) at the beginning of line 15 OR > (2) at a position that is outside the buffer (point 323 of 322). > > Case (1) is the expected behaviour, and case (2) is the issue I reported > and which, just FYI, also still arises with your patch applied. > > However, your patch also leads to the new problem that even in cases > where the point is not outside the buffer, it is unexpectedly placed at > the *end* of line 15 instead of at the beginning, where ediprolog-dwim > was invoked before the insertion is undone. > > In this sense, the behaviour is worse than before for #23871 with your > patch, because point is never restored to where the interaction started. I haven't started to look at 23871 yet, only 21722; I would rather deal with the simple case first. Can you tell me whether it fixes this case? Phil