From: Nicolas Petton <nicolas@petton.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 25929@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#25929: 25.2; map-delete doesn't delete permanently 1st alist elt
Date: Tue, 21 Mar 2017 12:35:35 +0100 [thread overview]
Message-ID: <87a88eq2uw.fsf@petton.fr> (raw)
In-Reply-To: <jwvbmtjwwdn.fsf-monnier+emacsbugs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (macroexp-let2 nil key
>> `(progn
>> (map--dispatch ,map
>> :list (setf (alist-get ,key ,map nil t) nil)
>> :hash-table (remhash ,key ,map)
>> :array (and (>= ,key 0)
>> (<= ,key (seq-length ,map))
>> (aset ,map ,key nil)))
>> ,map)))
>
> Note that this will make it pretty much impossible to use
> cl-generic dispatch.
Indeed, but I already have that issue. To use `cl-generic', map.el has
to be basically rewritten from scratch.
> A better option might be to provide a map-remove which works
> functionally (i.e. doesn't modify its argument by side-effects)
I'd love to have that, but what about performance issues with
hash-tables?
hash-tables aren't persistent collections, and having `map-remove',
`map-add', etc. work functionally, the hash-table would have
to be copied for each operation.
Cheers,
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2017-03-21 11:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 7:17 bug#25929: 25.2; map-delete doesn't delete permanently 1st alist elt Tino Calancha
2017-03-02 8:56 ` Nicolas Petton
2017-03-02 10:59 ` Nicolas Petton
2017-03-02 11:30 ` Tino Calancha
2017-03-02 12:27 ` Nicolas Petton
2017-03-02 12:34 ` Nicolas Petton
2017-03-02 13:34 ` Tino Calancha
2017-03-02 15:12 ` Stefan Monnier
2017-03-04 0:04 ` Michael Heerdegen
2017-03-04 0:16 ` Michael Heerdegen
2017-03-21 20:41 ` Lars Ingebrigtsen
2017-03-22 11:55 ` Michael Heerdegen
2017-03-22 12:01 ` Lars Ingebrigtsen
2017-03-22 12:56 ` Noam Postavsky
2017-03-22 13:31 ` Lars Ingebrigtsen
2017-03-22 14:43 ` Michael Heerdegen
2017-03-22 17:04 ` Stefan Monnier
2017-03-22 17:23 ` Lars Ingebrigtsen
2017-03-22 20:31 ` Stefan Monnier
2017-03-22 17:02 ` Stefan Monnier
2017-03-29 15:25 ` bug#25929: 25.2; plists and map-* Lars Ingebrigtsen
2017-03-29 15:36 ` Nicolas Petton
2017-03-21 11:35 ` Nicolas Petton [this message]
2017-03-21 15:11 ` bug#25929: 25.2; map-delete doesn't delete permanently 1st alist elt Stefan Monnier
2017-03-21 18:06 ` Nicolas Petton
2017-03-21 20:29 ` Stefan Monnier
2017-04-26 7:58 ` Nicolas Petton
2017-03-02 12:36 ` npostavs
2017-03-02 12:45 ` Nicolas Petton
2022-04-26 13:34 ` Lars Ingebrigtsen
2022-04-28 3:17 ` Richard Stallman
2022-04-28 16:00 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a88eq2uw.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=25929@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).