unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Petton <nicolas@petton.fr>
To: Damien Cassou <damien@cassou.me>, 26417@debbugs.gnu.org
Subject: bug#26417: 25.2; Add current-line in simple.el
Date: Wed, 12 Apr 2017 10:30:53 +0200	[thread overview]
Message-ID: <87a87m2fk2.fsf@petton.fr> (raw)
In-Reply-To: <87fuhhzwbe.fsf@cassou.me>

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Damien Cassou <damien@cassou.me> writes:

> Hi,

Hi Damien,

> attached patch adds `current-line' and its tests. This new 
> function returns the line number at given position ignoring 
> narrowing.

I know narrowing have no effect on `current-column', but does it make
sense to widen the buffer for `current-line'? (I don't have a strong
opinion, but I think it's worth asking the question).

Other than that, I think this is useful, thanks for the patch.

> I guess that `what-line' could be refactored using 
> `current-line'. I can do that if you want.

Yes, that'd be good.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

  reply	other threads:[~2017-04-12  8:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-09 10:53 bug#26417: 25.2; Add current-line in simple.el Damien Cassou
2017-04-12  8:30 ` Nicolas Petton [this message]
2017-04-12  8:52   ` Damien Cassou
2017-04-20  9:03     ` Nicolas Petton
2017-05-03 11:11       ` Damien Cassou
2017-05-03 14:37         ` Nicolas Petton
2017-05-03 15:38           ` Damien Cassou
2017-05-03 16:07             ` Nicolas Petton
2017-05-23 10:30               ` Damien Cassou
2017-06-16 13:46                 ` Damien Cassou
2017-06-16 14:30                   ` Nicolas Petton
2017-06-19  9:19                 ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a87m2fk2.fsf@petton.fr \
    --to=nicolas@petton.fr \
    --cc=26417@debbugs.gnu.org \
    --cc=damien@cassou.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).