From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc. Date: Fri, 30 Jun 2017 08:36:52 +0200 Message-ID: <87a84qx9q3.fsf@gmail.com> References: <87poegnnyn.fsf@gmail.com> <87tw3ng6ov.fsf@gnu.org> <878tkzc5fm.fsf@gmail.com> <87wp8eru6z.fsf@users.sourceforge.net> <87lgound82.fsf@gmail.com> <87o9t6ktso.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1498804696 7968 195.159.176.226 (30 Jun 2017 06:38:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Jun 2017 06:38:16 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 Cc: 27272@debbugs.gnu.org, Johan =?UTF-8?Q?Bockg=C3=A5rd?= To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 30 08:38:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQpZC-0001bx-1d for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jun 2017 08:38:10 +0200 Original-Received: from localhost ([::1]:42755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQpZE-00018L-2C for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jun 2017 02:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQpZ7-00018G-Fj for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2017 02:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQpZ4-0005NW-D6 for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2017 02:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQpZ4-0005N7-9J for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2017 02:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dQpZ3-0005wj-TC for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2017 02:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2017 06:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27272-submit@debbugs.gnu.org id=B27272.149880462422792 (code B ref 27272); Fri, 30 Jun 2017 06:38:01 +0000 Original-Received: (at 27272) by debbugs.gnu.org; 30 Jun 2017 06:37:04 +0000 Original-Received: from localhost ([127.0.0.1]:45379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQpY7-0005vX-RE for submit@debbugs.gnu.org; Fri, 30 Jun 2017 02:37:04 -0400 Original-Received: from mail-wm0-f68.google.com ([74.125.82.68]:34667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQpY6-0005v2-Gj for 27272@debbugs.gnu.org; Fri, 30 Jun 2017 02:37:02 -0400 Original-Received: by mail-wm0-f68.google.com with SMTP id p204so6147454wmg.1 for <27272@debbugs.gnu.org>; Thu, 29 Jun 2017 23:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=cMb9RNqkmWX9bj+JBzEm9RSVAgofYsKZAMfD2rKvzfM=; b=IwJlj288raE3zKyqFXSjTfXTg4+/TLOxXfNhfI1Hyz5m/Br0eGChHe4kgiYZ+WGW8f YPwvkjGOIh9065QBktUPSRgLhLC8jMxWB5wpoImYqJVBCzR1lhfoAlY/f0lTPemkbKLV U9VzbCqWrMba6XdNUsN8qUoK3GWKzxwku/bE5u6xHvRALw0vvmmCcMwU6K6XXPMQ0/R8 34BE0mYMFK13jKfQXnliw8CGnIoavRLqSIyJ0AZgVEQnYiryzzr+pICY3yfGyD12GiWY HenhD/FE8ATkV1pigVF5KHZ9P3JeD+XsQ36IV047KeYfFjpq0ucu8QLVIe/8qI3mr7I3 dA9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=cMb9RNqkmWX9bj+JBzEm9RSVAgofYsKZAMfD2rKvzfM=; b=odQpc0Uft9Lk1ldrCuHVaSU0OrF5PYnBuJMyFNyHRHBOPRj8B+tVxlxx8wJHUSTIpH 37tsy3esCcdL+MZMM9MYMUw6DBbtwATgvXcsDJNnt8KLl55zUVkMZO6cLHCzfc/bXvFX KtzYjcEYVgOXNxVKPZ1ELhPasVxZyCV5xLGXVvqt0V+sB5YvKt/xSlPT6lRuRjxUonaZ WWxGOBPdEGesbsVSL87X93LXzdAtZtmMQ6D/GrcIDrzQsE71H7s7JOPqom/EtXwXSZDR 63S22iKGYGZKelaEw/XC3+/ULdV1JnPocpPJazbb+VuZy5jq5OqdD8t69wrInkMDnleJ emnA== X-Gm-Message-State: AKS2vOyV4XDAkZi+cKaGfYHvbITALTVh2LJgli6Ea6G/rLK7P5oTg66W lcEsM+y880cWlg== X-Received: by 10.28.6.77 with SMTP id 74mr4263140wmg.96.1498804616703; Thu, 29 Jun 2017 23:36:56 -0700 (PDT) Original-Received: from dell-14z ([179.43.163.98]) by smtp.gmail.com with ESMTPSA id 2sm4585705wrn.24.2017.06.29.23.36.54 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 29 Jun 2017 23:36:55 -0700 (PDT) In-reply-to: <87o9t6ktso.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134052 Archived-At: npostavs@users.sourceforge.net writes: > Thierry Volpiatto writes: > >> npostavs@users.sourceforge.net writes: >> >>> Do you mean you have an updated patch that fixes this as well (which you >>> seem to have forgotten to post)? >> >> It is here. > > I get a compile warning > > In elisp--highlight-function-argument: > ../../emacs-master/lisp/progmodes/elisp-mode.el:1404:44:Warning: reference to > free variable ‘args-lst’ > > and then at run-time eldoc is non-functional, it just prints > > eldoc error: (void-variable args-lst) This patch is an adaptation of what I use in my .emacs.el, originally the patch was correct, I have then deleted it (because the patch was refused) and then created it again on your request, forgetting to merge one line; Use let* instead of let. Don't expect me to send another patch for such trivial change and more generally to collaborate anymore on any emacs bugs. -- Thierry Gpg Key fingerprint = 6CEC 7081 AB33 E251 4AB8 5FC2 28D1 7F53 59F2 9997