From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28066@debbugs.gnu.org, rms@gnu.org, yegortimoshenko@gmail.com
Subject: bug#28066: eshell-tramp sudo ignores C-c
Date: Mon, 21 Aug 2017 17:01:34 +0200 [thread overview]
Message-ID: <87a82t9d81.fsf@detlef> (raw)
In-Reply-To: <83tw11at17.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Aug 2017 17:34:44 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: rms@gnu.org, 28066@debbugs.gnu.org, yegortimoshenko@gmail.com
>> Date: Mon, 21 Aug 2017 13:36:06 +0200
>>
>> > In such cases, we usually provide a variable whose value is a
>> > function. The default value is a function that does whatever
>> > interrupt-process is doing now, and Tramp can replace it with its own
>> > function.
>> >
>> > Does this make sense in your case?
>>
>> What about the appended patch?
>
> LGTM, but did you consider to define the variable in Lisp?
Sure, Vinterrupt_process_functions is declared with DEFVAR_LISP, see the
end of the patch. And it works, I've tested already my changed Tramp
implementation :-)
Anyway, I'll commit it to the master. People could raise their concerns
then, if any. Updating the documentation will be the next step afterwards.
Best regards, Michael.
next prev parent reply other threads:[~2017-08-21 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 14:45 bug#28066: eshell-tramp sudo ignores C-c Yegor Timoshenko
2017-08-13 8:39 ` Michael Albinus
2017-08-14 1:51 ` Richard Stallman
2017-08-20 19:29 ` Michael Albinus
2017-08-20 19:37 ` Eli Zaretskii
2017-08-20 19:46 ` Michael Albinus
2017-08-21 11:36 ` Michael Albinus
2017-08-21 14:34 ` Eli Zaretskii
2017-08-21 15:01 ` Michael Albinus [this message]
2017-08-20 22:31 ` Yegor Timoshenko
2017-08-21 7:29 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a82t9d81.fsf@detlef \
--to=michael.albinus@gmx.de \
--cc=28066@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rms@gnu.org \
--cc=yegortimoshenko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).