From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#28605: 26.0.60; Part of leftmost character hidden Date: Fri, 06 Oct 2017 13:50:12 +0200 Message-ID: <87a8145wcr.fsf@gmail.com> References: <59CB5D69.7040404@gmx.at> <59CE05F2.1010202@gmx.at> <59CE8E74.5010308@gmx.at> <59D35549.6030905@gmx.at> <87wp4c750c.fsf@gmail.com> <59D4A45F.5010606@gmx.at> <87tvzfjfcp.fsf@gmail.com> <59D5E8F6.8080002@gmx.at> <87efqikk0x.fsf@gmail.com> <87a815lq3w.fsf@gmail.com> <59D73C6F.3020907@gmx.at> <87o9pk65ae.fsf@gmail.com> <59D74E49.2000605@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507290770 23776 195.159.176.226 (6 Oct 2017 11:52:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 11:52:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: Ola Nilsson , Lars Magne Ingebrigtsen , 28605@debbugs.gnu.org, Kaushal To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 06 13:52:46 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0RBL-0005QP-Gk for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Oct 2017 13:52:43 +0200 Original-Received: from localhost ([::1]:44249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0RBS-0006wI-RO for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Oct 2017 07:52:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0R9o-0005v8-Bu for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 07:51:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0R9i-0005kG-R0 for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 07:51:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0R9i-0005jf-MY for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 07:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0R9i-0006Hz-Fc for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 07:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2017 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28605-submit@debbugs.gnu.org id=B28605.150729063024130 (code B ref 28605); Fri, 06 Oct 2017 11:51:02 +0000 Original-Received: (at 28605) by debbugs.gnu.org; 6 Oct 2017 11:50:30 +0000 Original-Received: from localhost ([127.0.0.1]:52234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0R9C-0006H7-54 for submit@debbugs.gnu.org; Fri, 06 Oct 2017 07:50:30 -0400 Original-Received: from mail-wr0-f173.google.com ([209.85.128.173]:45115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0R9A-0006Gr-9F for 28605@debbugs.gnu.org; Fri, 06 Oct 2017 07:50:28 -0400 Original-Received: by mail-wr0-f173.google.com with SMTP id k7so1863831wre.2 for <28605@debbugs.gnu.org>; Fri, 06 Oct 2017 04:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=6cAXHrLP9rqVwHygGUDpDuM/BDoKgRuc5BuSWdEu9hE=; b=KNMkkK5RgVUSKNE+YaSN8YRlp68AUGnxcY7ea3nnlFyNATn01F6vhKwIC/DzeqX9T4 LJK9YPZeUbi/ygUg2qRpv1stM2bORbNpJvMaIqkcX+Dk7bDC51sTSpfO1evmREH8VP+Q FfZJmyyRGhvgzLweCPpBKWxdfLaitPSdFirbWvMuLu2LqrVFLDRJzC4U8hBI7smrVwKW FOAhQfyH8Fy5RpcjbE5sNPpfw1hiV3OQ/2CL9/zsmHFtT96H4d+VmPGKwRwJr4/dNpKA wLDORAC4nVGKMKhPtt0HB73UzGQRrdcrcfdK5rXmj5oWIHXnAK8G+XMhznL6J8/HE3M1 DTaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=6cAXHrLP9rqVwHygGUDpDuM/BDoKgRuc5BuSWdEu9hE=; b=nZJ4YQ+rmZe0k+6w9828J6n3n1pGKIdmAM9O832UMoHks9dwATMCkPZY3LXf/zNWUD CgxXyQzi3Llsm0MloBkmWyMOge/nCnkL1Rvxg7fZvQ7TWS1343u+2u63RiPp0f8fXv8R SLpAqaCcJRBYIf33ElGOVyawF45cGXXNO8L6/+P8j8uDdohKmrnxeJ1Q27hgErhFUp4U lHB/KuQm7M9VSgQ7QRHqPz27W5hHXng1IQfvISK+wcUcoqlZ+AY3XEXdlTtGbimYSy8L cR4mJ5QRLHW/54OBWJJhMvoy6TQ1G0y/DNg260vkfdyaROj4om21z0snJw73hGzNxicj 8DYA== X-Gm-Message-State: AMCzsaU4qU5p0xE4A1Gg9f7E941mA/zSzhB/bIIpamhnXBYJ7e6/Bvue LHmAZBiXcUJ5OYvWoXP0EDdtjC+tFDQ= X-Google-Smtp-Source: AOwi7QBRnEjnfLiSzw/lXX+qnrIIUTMZ4OeCP+ETnB+Yyajpk7pgv74qDUjtQxxBWbydnD+bT6AXsQ== X-Received: by 10.223.161.219 with SMTP id v27mr1676529wrv.193.1507290622018; Fri, 06 Oct 2017 04:50:22 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id k9sm2753953wrk.27.2017.10.06.04.50.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2017 04:50:20 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <59D74E49.2000605@gmx.at> (martin rudalics's message of "Fri, 06 Oct 2017 11:35:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138012 Archived-At: martin rudalics writes: >> OK. The best course of action is then probably not to touch the >> existing adjustments, and not to add any similar ones for the >> horizontal case. > > Lars already touched them and IIUC provoked this bug. > Lars' HiDPI changes were a huge improvement over what was there before. I'm talking here only about leaving alone the x_clear_area code, but still changing the width calculation. >>>> That code was added in commit c0055ff5b03c9121ab5bf752496b09416f0f0a7d >>>> which is quite old, >>> >>> ... 2015 rather strikes me as "fairly recent" ... >>> >> >> Oops, I think I looked at the date on the wrong commit, I thought I'd >> seen 2010. > > OTOH this means that the code was not tested very intensively and Jan > didn't have much time left to improve it. > >>>> I suspect it did no real harm even though oldx >>>> tends to end up negative, possibly x_clear_area does some kind of >>>> clipping. >>> >>> In my experience, X silently swallows anything that happens outside the >>> frame. GTK can be much more picky in this regard, especially when >>> trying to draw something outside a parent widget. But the corresponding >>> error messages are usually a pain to read. >> >> Yet another reason not to disturb the status quo. > > To be on the safe side, we probably should leave the non-scaling parts > alone. For the scaling parts do whatever you consider appropriate. If > it fixes the behavior for Ola, we should install it and wait for > complaints. OK, I'll wait for Ola confirm, then clean it up (and split it into at least 2 to make it easier to revert). Robert