From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 28797@debbugs.gnu.org, kaushal.modi@gmail.com
Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired
Date: Tue, 24 Oct 2017 19:33:30 -0400 [thread overview]
Message-ID: <87a80gce9h.fsf@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1710250033470.25693@calancha-pc> (Tino Calancha's message of "Wed, 25 Oct 2017 00:41:23 +0900 (JST)")
Tino Calancha <tino.calancha@gmail.com> writes:
> On Sun, 22 Oct 2017, Noam Postavsky wrote:
>
>>The "no" case of dired-test-bug27940 is failing now. I guess if
>>RECURSIVE is set to nil, we should not try to delete non-empty
>>directories, or maybe just catch the error if it happens?
Just to clarify, I wrote this before I had figured the Bug#11218 issue.
We *are* currently catching the error, but due to Bug#11218 catching
with condition-case-unless-debug (as opposed to condition-case) doesn't
work inside ert tests.
> * lisp/dired (dired-delete-file): If the dir is non-empty and
> RECURSIVE is nil then return 'skip and don't try to delete
> the dir (Bug#28797).
I think it's okay to do this if we think it would be better for users to
avoid triggering the error messages altogether. But it should be a
separate decision from whether we want condition-case or
condition-case-unless-debug.
next prev parent reply other threads:[~2017-10-24 23:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 14:56 bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Kaushal Modi
2017-10-12 15:08 ` Noam Postavsky
2017-10-13 3:16 ` Noam Postavsky
2017-10-13 8:58 ` Eli Zaretskii
2017-10-13 13:15 ` Noam Postavsky
2017-10-13 13:43 ` Eli Zaretskii
2017-10-22 16:28 ` Noam Postavsky
2017-10-24 15:41 ` Tino Calancha
2017-10-24 23:33 ` Noam Postavsky [this message]
2017-11-05 17:20 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a80gce9h.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=28797@debbugs.gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).