From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Date: Sat, 02 Dec 2017 16:32:16 +0900 Message-ID: <87a7z1vb3z.fsf@gmail.com> References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> <83mv323kvx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512199992 17008 195.159.176.226 (2 Dec 2017 07:33:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Dec 2017 07:33:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29465@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 02 08:33:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL2IL-00041C-QM for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Dec 2017 08:33:06 +0100 Original-Received: from localhost ([::1]:34647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL2IT-0004jF-3q for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Dec 2017 02:33:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL2IM-0004jA-50 for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 02:33:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL2IJ-0003xi-0P for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 02:33:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60492) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eL2II-0003xV-Rq for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 02:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eL2II-000686-Dl for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 02:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151219994823519 (code B ref 29465); Sat, 02 Dec 2017 07:33:02 +0000 Original-Received: (at 29465) by debbugs.gnu.org; 2 Dec 2017 07:32:28 +0000 Original-Received: from localhost ([127.0.0.1]:40940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL2Hk-00067H-IG for submit@debbugs.gnu.org; Sat, 02 Dec 2017 02:32:28 -0500 Original-Received: from mail-wm0-f48.google.com ([74.125.82.48]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL2Hj-000673-7h for 29465@debbugs.gnu.org; Sat, 02 Dec 2017 02:32:27 -0500 Original-Received: by mail-wm0-f48.google.com with SMTP id f9so6741111wmh.0 for <29465@debbugs.gnu.org>; Fri, 01 Dec 2017 23:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=w8kwXMpobtrSQVd7cq8Xh+Ccz/5kihGssJhDqRPq0GQ=; b=ECtOfV1EUPZtvxCJjGr1a4UTKGY4TkOF7H7l+b47NQyQsJvHK+eyr06M2GdM9kCUHX jufMr+Ofjhsh6AhwE0Dey/4+/Xl+rHap2zKBfgwgx8sJJKisZPT0G1ZuQNOBjghKbaiF N7I8V6KqIlgho8kkkx1vrlr/aJ/b9YIGYXPNSdf4Cw346o/YT57FdsZFAMZ6TfgiFsNL KlZnO6sGpd6mjk2kL0DOwyGREP6ps+zbVwZJoX1nJ/2Yrugnt66VG8Dvg17uzN9gCTCz RerWiFO0/vPsgyp98A4k9bfQyuP1tihgbKrMOHnceEf/5fa8QEthZeFiuN/2vXqRX4N1 m38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=w8kwXMpobtrSQVd7cq8Xh+Ccz/5kihGssJhDqRPq0GQ=; b=ZzPpR88WCi6tJbHX/KeA/VeYUoBlBZ/Bo+LiaWosnWv/1BDbGQgerQu538kwniF76+ fn8TiAGSHymkCDcTQTQiogwYjNNgq9nvGk8tnjdspHNjPKJAz7zKAfVeIqsttmW0G8pi 15/m6a/uTSWheGeln98W3gPES3GGL8jemn45zqNTEQl5Ju+VFlYN+bXwCiA3Og12tvf0 5O7sbt6BNOTk/Co+f+XWvfMe6db1rF4fgnhcVyTsYdPea8wC0zHid0tW5aVzLpM9bvGC Wr57i/Kqz9HTqs0+90LSx7tT0sno7HDCdw5to7ffKmBAuIG9Kp5bXggqK4Iklbwxcy1n J5BQ== X-Gm-Message-State: AKGB3mIWZFVX1QRYRLQh0BP6zSYWoHbLXeqOKOm2nqJ9beM50cPgEicd kGg1uLxp6zJZxfS0A10LffQ= X-Google-Smtp-Source: AGs4zMbQey9ynAcpUEFQJ9xyvSW/pmcuQL4Z5jO8Gwkl9rgD0lxBueRM1/eQQFgH35IeV1Vc2ZH4Ng== X-Received: by 10.28.105.76 with SMTP id e73mr2816410wmc.116.1512199941525; Fri, 01 Dec 2017 23:32:21 -0800 (PST) Original-Received: from calancha-pc (228.red-83-40-68.dynamicip.rima-tde.net. [83.40.68.228]) by smtp.gmail.com with ESMTPSA id b16sm11580011wrd.69.2017.12.01.23.32.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 23:32:20 -0800 (PST) In-Reply-To: (Allen Li's message of "Fri, 1 Dec 2017 22:31:03 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140614 Archived-At: Allen Li writes: Thank you for the new patches Allen! I don't have strong opinions on this thread; probably because I am already in Christmass mode or something... Anyway, I think you guys are discussing pretty well the thing! I have just two comments in the second patch: > +;;;###autoload > +(defcustom dired-confirm-shell-command t > + "Whether to prompt for confirmation for Dired shell commands. > +If t, prompt" > + :type '(choice (const :tag "No restrictions" nil) > + (const :tag "When point is on a file name initially, search file names" dwim) > + (const :tag "Always search in file names" t)) > + :group 'dired > + :version "26.0") ^^^^ * Version must be 26.1 * The :type looks unrelated with the option. Maybe better something like this: :type '(choice (const :tag "Ask confirmation" t) (const :tag "Never ask confirmation" nil)) > + > - (string-match regexp res)))) > + (when > + dired-confirm-shell-command > + (let ((res cmd) You might put the option in the same line as `when', i.e.: (when dired-confirm-shell-command