From: Tino Calancha <tino.calancha@gmail.com>
To: Allen Li <vianchielfaura@gmail.com>
Cc: 29465@debbugs.gnu.org
Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution
Date: Sat, 02 Dec 2017 16:32:16 +0900 [thread overview]
Message-ID: <87a7z1vb3z.fsf@gmail.com> (raw)
In-Reply-To: <CAJr1M6fx7YTmta28JwcUb=LmjCZ8ayaLPtHqZBOcZ+PGBBU93Q@mail.gmail.com> (Allen Li's message of "Fri, 1 Dec 2017 22:31:03 -0800")
Allen Li <vianchielfaura@gmail.com> writes:
Thank you for the new patches Allen!
I don't have strong opinions on this thread; probably because
I am already in Christmass mode or something... Anyway, I think
you guys are discussing pretty well the thing!
I have just two comments in the second patch:
> +;;;###autoload
> +(defcustom dired-confirm-shell-command t
> + "Whether to prompt for confirmation for Dired shell commands.
> +If t, prompt"
> + :type '(choice (const :tag "No restrictions" nil)
> + (const :tag "When point is on a file name initially, search file names" dwim)
> + (const :tag "Always search in file names" t))
> + :group 'dired
> + :version "26.0")
^^^^
* Version must be 26.1
* The :type looks unrelated with the option.
Maybe better something like this:
:type '(choice (const :tag "Ask confirmation" t)
(const :tag "Never ask confirmation" nil))
> +
> - (string-match regexp res))))
> + (when
> + dired-confirm-shell-command
> + (let ((res cmd)
You might put the option in the same line as `when', i.e.:
(when dired-confirm-shell-command
next prev parent reply other threads:[~2017-12-02 7:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 7:16 bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Allen Li
2017-11-27 7:34 ` Allen Li
2017-11-27 9:07 ` Michael Heerdegen
2017-11-27 15:58 ` Eli Zaretskii
2017-11-28 3:50 ` Tino Calancha
2017-11-28 8:25 ` Allen Li
2017-11-28 16:26 ` Eli Zaretskii
2017-11-28 20:13 ` Allen Li
2017-11-29 4:20 ` Drew Adams
2017-12-01 8:36 ` Eli Zaretskii
2017-12-02 6:31 ` Allen Li
2017-12-02 7:32 ` Tino Calancha [this message]
2017-12-02 8:22 ` Allen Li
2022-03-22 16:48 ` Lars Ingebrigtsen
2017-11-28 16:15 ` Eli Zaretskii
[not found] <<CAJr1M6f71vv2W090wPw8q_10wK=OwfgvMfM7DMiPn9G8oyY8AA@mail.gmail.com>
[not found] ` <<83vahv67eb.fsf@gnu.org>
[not found] ` <<87fu8zukmb.fsf@gmail.com>
[not found] ` <<CAJr1M6cuB0RPcUfzsGHCGt+8m6-KH58FX4NoD==APb7dksrs2g@mail.gmail.com>
[not found] ` <<83609u5pyr.fsf@gnu.org>
[not found] ` <<CAJr1M6cT578dcFT4Uvg29===-q=7omx5DG+JSTuqczjO3paGgg@mail.gmail.com>
[not found] ` <<29b407d1-e1f6-4676-a686-ccdf19af8bb4@default>
[not found] ` <<83mv323kvx.fsf@gnu.org>
2017-12-01 15:42 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7z1vb3z.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=29465@debbugs.gnu.org \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).