* bug#31192: 27.0.50; artist-mode throws a wrong type argument
@ 2018-04-17 12:57 Tino Calancha
2018-04-17 13:00 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Tino Calancha @ 2018-04-17 12:57 UTC (permalink / raw)
To: 31192; +Cc: lars ingebrigtsen
X-Debbugs-CC: Lars Ingebrigtsen <larsi@gnus.org>
After commit '(artist-mode): Warn about proportional fonts'
(36e5673753b985dee06b255be237dce9e96b0eb7)
emacs -batch -eval "(artist-mode)"
throws
Wrong type argument: font, unspecified
That causes two ibuffer-tests.el to fail:
(ibuffer-filter-inclusion-7, ibuffer-filter-inclusion-8)
--8<-----------------------------cut here---------------start------------->8---
commit 04f528b864490f22e773d185f2a4980b29306eb0
Author: Tino Calancha <tino.calancha@gmail.com>
Date: Tue Apr 17 21:34:25 2018 +0900
* lisp/textmodes/artist.el (artist-mode): Ensure we have a font
diff --git a/lisp/textmodes/artist.el b/lisp/textmodes/artist.el
index 7c261f8d2d..e9ae6a4ce9 100644
--- a/lisp/textmodes/artist.el
+++ b/lisp/textmodes/artist.el
@@ -1402,8 +1402,9 @@ artist-mode
(t
;; Turn mode on
(artist-mode-init)
- (unless (font-get (face-attribute 'default :font) :spacing)
- (message "The default font isn't monospaced, so the drawings in this buffer may look odd")))))
+ (let ((font (face-attribute 'default :font)))
+ (when (and (fontp font) (not (font-get font :spacing)))
+ (message "The default font isn't monospaced, so the drawings in this buffer may look odd"))))))
;; Init and exit
(defun artist-mode-init ()
--8<-----------------------------cut here---------------end--------------->8---
In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
of 2018-04-17
Repository revision: 003071346cdc914f28a8e8b3a8bf0c8f5f3b52dc
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#31192: 27.0.50; artist-mode throws a wrong type argument
2018-04-17 12:57 bug#31192: 27.0.50; artist-mode throws a wrong type argument Tino Calancha
@ 2018-04-17 13:00 ` Lars Ingebrigtsen
2018-04-17 13:19 ` Tino Calancha
2018-04-17 13:22 ` Tino Calancha
0 siblings, 2 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2018-04-17 13:00 UTC (permalink / raw)
To: Tino Calancha; +Cc: 31192
Tino Calancha <tino.calancha@gmail.com> writes:
> * lisp/textmodes/artist.el (artist-mode): Ensure we have a font
Makes sense. Are you applying it or do you want me to? :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#31192: 27.0.50; artist-mode throws a wrong type argument
2018-04-17 13:00 ` Lars Ingebrigtsen
@ 2018-04-17 13:19 ` Tino Calancha
2018-04-17 13:22 ` Tino Calancha
1 sibling, 0 replies; 4+ messages in thread
From: Tino Calancha @ 2018-04-17 13:19 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 31192, Tino Calancha
On Tue, 17 Apr 2018, Lars Ingebrigtsen wrote:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> * lisp/textmodes/artist.el (artist-mode): Ensure we have a font
>
> Makes sense. Are you applying it or do you want me to? :-)
HeheHe, in your house or in mine? :-)
OK, I will do it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#31192: 27.0.50; artist-mode throws a wrong type argument
2018-04-17 13:00 ` Lars Ingebrigtsen
2018-04-17 13:19 ` Tino Calancha
@ 2018-04-17 13:22 ` Tino Calancha
1 sibling, 0 replies; 4+ messages in thread
From: Tino Calancha @ 2018-04-17 13:22 UTC (permalink / raw)
To: 31192-done
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> * lisp/textmodes/artist.el (artist-mode): Ensure we have a font
>
> Makes sense.
Fixed in master branch with commit
'* lisp/textmodes/artist.el (artist-mode): Ensure we have a font'
(c969fbd40bcad0de6322895a5ad4d53144309315)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-17 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-17 12:57 bug#31192: 27.0.50; artist-mode throws a wrong type argument Tino Calancha
2018-04-17 13:00 ` Lars Ingebrigtsen
2018-04-17 13:19 ` Tino Calancha
2018-04-17 13:22 ` Tino Calancha
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).