unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31988@debbugs.gnu.org, 31988-done@debbugs.gnu.org
Subject: bug#31988: scroll-other-window broken on master
Date: Sat, 07 Jul 2018 16:40:17 +0300	[thread overview]
Message-ID: <87a7r317we.fsf@tcd.ie> (raw)
In-Reply-To: <83pnzzjxl5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 7 Jul 2018 10:48:06 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Fri, 6 Jul 2018 16:31:24 -0700
>> From: "Daniel Colascione" <dancol@dancol.org>
>> Cc: 31988@debbugs.gnu.org
>> 
>> > I don't have push access, so someone else will have to apply the patch
>> > for me if there are no objections to it.
>> 
>> I just applied it. Thanks!
>
> Thanks, but why didn't you use the commit log Basil provided?  (It was
> somewhat inaccurate, but more informative than what you used, IMO.)

Thanks Daniel for applying the patch and Eli for your subsequent
efficiency and documentation fix.

I don't yet feel particularly good at or confident with writing
changelog entries, let alone Emacs C code, so any guidance is more than
welcome now and in the future.

I'm not sure whether Daniel's addition of the 'close' tag had the
intended effect, so I'm taking the liberty of CCing
<31988-done@debbugs.gnu.org>; if this was the wrong thing to do, please
let me know what I should have done instead.

Thanks again,

-- 
Basil





  reply	other threads:[~2018-07-07 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 19:54 bug#31988: scroll-other-window broken on master Daniel Colascione
2018-06-27 20:44 ` Daniel Colascione
2018-06-27 21:26   ` Basil L. Contovounesios
2018-07-06 15:18     ` Daniel Colascione
2018-07-06 22:20       ` Basil L. Contovounesios
2018-07-06 23:31         ` Daniel Colascione
2018-07-07  7:48           ` Eli Zaretskii
2018-07-07 13:40             ` Basil L. Contovounesios [this message]
2018-07-07 13:50               ` Eli Zaretskii
2018-07-07 14:14                 ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7r317we.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=31988-done@debbugs.gnu.org \
    --cc=31988@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).