unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: fangtao0901 <fangtao0901@gmail.com>
Cc: 31704@debbugs.gnu.org
Subject: bug#31704: fixed commit not handle eshell-path-env properly in Windows platform
Date: Wed, 25 Jul 2018 11:03:27 +0200	[thread overview]
Message-ID: <87a7qf8z6o.fsf@gmx.de> (raw)
In-Reply-To: <tbokrj96mx8us0twifsam7qd.1532487423104@email.android.com> (fangtao's message of "Wed, 25 Jul 2018 11:24:03 +0800")

fangtao0901 <fangtao0901@gmail.com> writes:

> Hi, Michael

Hi,

>   I'm using git master branch daily build emacs on Windows platform,
> after this commit to fix bug#31704, running commands directly in
> eshell always gives output "command not found".
>   The cause of this is in lisp/net/tramp.el, function
> tramp-eshell-directory-change modify eshell-path-env not properly:
>   (mapconcat 'identity (butlast (tramp-compat-exec-path)) ":")
>   I think variable path-separator should be used instead of ":"

I confirm the problem. However, your proposal doesn't fix it for me.

Are you sure this is a new problem? I've tried Emacs 26.1 on MS Windows,
and I get a similar error.

> Best regards,

Best regards, Michael.





  reply	other threads:[~2018-07-25  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04  1:32 bug#31704: 26.1; tramp-remote-path/shell: broken executable completion xristos
2018-06-05  9:58 ` Michael Albinus
2018-06-20 10:17   ` Michael Albinus
2018-07-25  3:24 ` bug#31704: fixed commit not handle eshell-path-env properly in Windows platform fangtao0901
2018-07-25  9:03   ` Michael Albinus [this message]
2018-07-26  4:37     ` Tao Fang
2018-09-06 10:21       ` Michael Albinus
2018-09-10  0:50         ` Tao Fang
2018-09-10  7:54           ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7qf8z6o.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=31704@debbugs.gnu.org \
    --cc=fangtao0901@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).