From: Noam Postavsky <npostavs@gmail.com>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: Kevin Ryde <user42_kevin@yahoo.com.au>, 33133@debbugs.gnu.org
Subject: bug#33133: 26.1.50; zlib-decompress-region too rigid
Date: Tue, 23 Oct 2018 20:26:59 -0400 [thread overview]
Message-ID: <87a7n4mbos.fsf@gmail.com> (raw)
In-Reply-To: <b4my3aow9bt.fsf@jpl.org> (Katsumi Yamaoka's message of "Wed, 24 Oct 2018 08:07:50 +0900")
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Whereas `gzip -d' does, zlib-decompress-region doesn't decompress
> corrupted data of a certain kind. For instance, visiting
>
> https://www.gutenberg.org/no-such-page-exists
>
> using eww shows raw gzipped data. The data extracted is attached.
> As for `gzip -d', it says "unexpected end of file" in stderr.
> If there is no prospect to improve zlib-decompress-region, how
> about this workaround?
We could have zlib-decompress-region ignore unexpected eof as well,
e.g., the below (though it should obviously be enhanced to depend on a
new parameter):
--- i/src/decompress.c
+++ w/src/decompress.c
@@ -206,7 +206,7 @@ DEFUN ("zlib-decompress-region", Fzlib_decompress_region,
}
while (inflate_status == Z_OK);
- if (inflate_status != Z_STREAM_END)
+ if (inflate_status != Z_STREAM_END && inflate_status != Z_BUF_ERROR)
return unbind_to (count, Qnil);
unwind_data.start = 0;
next prev parent reply other threads:[~2018-10-24 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 23:07 bug#33133: 26.1.50; zlib-decompress-region too rigid Katsumi Yamaoka
2018-10-24 0:26 ` Noam Postavsky [this message]
2018-10-24 1:16 ` Katsumi Yamaoka
2018-10-27 21:48 ` Noam Postavsky
2018-10-28 15:41 ` Eli Zaretskii
2018-10-31 0:25 ` Noam Postavsky
2018-10-31 16:07 ` Eli Zaretskii
2019-04-03 2:09 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7n4mbos.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=33133@debbugs.gnu.org \
--cc=user42_kevin@yahoo.com.au \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).