From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Date: Fri, 23 Nov 2018 00:16:46 +0200 Organization: LINKOV.NET Message-ID: <87a7m0hi5t.fsf@mail.linkov.net> References: <9B715204-BE6D-4F02-B484-1EA9EDACE0EB@scratch.space> <87wope15gh.fsf@mail.linkov.net> <4D07BB6C-98A9-4EC2-BB37-097D5D753E53@scratch.space> <87wopbzeuy.fsf@mail.linkov.net> <87d0r04tmg.fsf@mail.linkov.net> <87sgzv747k.fsf@mail.linkov.net> <740AF1DA-7EDB-4310-8C6E-F7944D714513@scratch.space> <87sgzuca5o.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1542927016 11799 195.159.176.226 (22 Nov 2018 22:50:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Nov 2018 22:50:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33398@debbugs.gnu.org To: Van L Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 22 23:50:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPxnX-0002wz-RC for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2018 23:50:12 +0100 Original-Received: from localhost ([::1]:49629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPxpc-0005F5-By for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2018 17:52:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPxpT-0005EF-6u for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2018 17:52:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPxpQ-00056W-2I for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2018 17:52:11 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPxpP-00056H-Ud for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2018 17:52:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPxpP-0006Vm-Rt for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2018 17:52:07 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Nov 2018 22:52:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33398-submit@debbugs.gnu.org id=B33398.154292710724794 (code B ref 33398); Thu, 22 Nov 2018 22:52:07 +0000 Original-Received: (at 33398) by debbugs.gnu.org; 22 Nov 2018 22:51:47 +0000 Original-Received: from localhost ([127.0.0.1]:42789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPxp4-0006Ro-Nj for submit@debbugs.gnu.org; Thu, 22 Nov 2018 17:51:46 -0500 Original-Received: from indri.birch.relay.mailchannels.net ([23.83.209.92]:10752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPxp2-0006Rf-OH for 33398@debbugs.gnu.org; Thu, 22 Nov 2018 17:51:45 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 19A9F682595; Thu, 22 Nov 2018 22:51:43 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C55166829FD; Thu, 22 Nov 2018 22:51:42 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 22 Nov 2018 22:51:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Trouble-Blushing: 1016f48437395639_1542927102933_3877632405 X-MC-Loop-Signature: 1542927102933:632064907 X-MC-Ingress-Time: 1542927102932 Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id 8AA5E7FE7B; Thu, 22 Nov 2018 14:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=L0xn0X IWWOpi/ln/OYjWVN4ZMSI=; b=O9iiWTqid7nrzQvPn/j0miXB1cKgE505rMNgeK g48TZZmUqjL9YxcCgQCjUJOnQcyZZPMhQNQMK3cURUeQTrHImtx4psa1qE5RyWgD 8mEKiKi5irR8yhgK1+H6dSDd3ofQd+6f8nAGWtp8Cg1HDs7yt7RjCieTi6dxzR37 Nu0lw= Original-Received: from mail.jurta.org (m91-129-105-252.cust.tele2.ee [91.129.105.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id C98857FE77; Thu, 22 Nov 2018 14:51:40 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a37 In-Reply-To: (Van L.'s message of "Thu, 22 Nov 2018 11:32:24 +1100") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddutddgtdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrddvhedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrvdehvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehvrghnsehstghrrghttghhrdhsphgrtggvnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152693 Archived-At: >>> The rainbow/artist=E2=80=99s coloring pencils theme for hi-faces is n= icer to >>> have for the wm-frame-windowing environment. > > The ROYGBIV palette for hi-lock-faces as theme. There is one palette in vc-annotate-color-map, but it doesn't look good when used for highlighting. >>>> The same way as hi-yellow is defined to use yellow, and hi-green >>>> to use green, we can define hi-blue to use blue color, and >>>> hi-pink to use red color. This will free cyan and magenta >>>> to use. >>=20 >> I guess there are no hi-magenta and hi-cyan faces because >> Isearch uses the magenta color for the current match and the >> cyan color for lazy-highlighted matches. >>=20 >> But OTOH, on TTY magenta and cyan are used from hi-pink and hi-blue, >> and there is no problem, so we can define two new hi-lock faces. The existing hi-blue face's color "light blue" is closer to the existing lazy-highlight face's color "paleturquoise" than to the new hi-cyan face's color "DarkSlateGray1" proposed in the patch below, so this color choice will be better then existing: diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el index 08b58117dd..95d7f867df 100644 --- a/lisp/hi-lock.el +++ b/lisp/hi-lock.el @@ -157,8 +157,11 @@ hi-yellow :group 'hi-lock-faces) =20 (defface hi-pink - '((((background dark)) (:background "pink" :foreground "black")) - (t (:background "pink"))) + '((((min-colors 88) (background dark)) + (:background "pink" :foreground "black")) + (((background dark)) (:background "red" :foreground "black")) + (((min-colors 88)) (:background "pink")) + (t (:background "red"))) "Face for hi-lock mode." :group 'hi-lock-faces) =20 @@ -172,8 +175,29 @@ hi-green :group 'hi-lock-faces) =20 (defface hi-blue - '((((background dark)) (:background "light blue" :foreground "black")) - (t (:background "light blue"))) + '((((min-colors 88) (background dark)) + (:background "light blue" :foreground "black")) + (((background dark)) (:background "blue" :foreground "black")) + (((min-colors 88)) (:background "light blue")) + (t (:background "blue"))) + "Face for hi-lock mode." + :group 'hi-lock-faces) + +(defface hi-magenta + '((((min-colors 88) (background dark)) + (:background "orchid1" :foreground "black")) + (((background dark)) (:background "magenta" :foreground "black")) + (((min-colors 88)) (:background "orchid1")) + (t (:background "magenta"))) + "Face for hi-lock mode." + :group 'hi-lock-faces) + +(defface hi-cyan + '((((min-colors 88) (background dark)) + (:background "DarkSlateGray1" :foreground "black")) + (((background dark)) (:background "cyan" :foreground "black")) + (((min-colors 88)) (:background "DarkSlateGray1")) + (t (:background "cyan"))) "Face for hi-lock mode." :group 'hi-lock-faces) =20 @@ -189,13 +213,13 @@ hi-blue-b :group 'hi-lock-faces) =20 (defface hi-green-b - '((((min-colors 88)) (:weight bold :foreground "green1")) + '((((min-colors 88)) (:weight bold :foreground "green3")) (t (:weight bold :foreground "green"))) "Face for hi-lock mode." :group 'hi-lock-faces) =20 (defface hi-red-b - '((((min-colors 88)) (:weight bold :foreground "red1")) + '((((min-colors 88)) (:weight bold :foreground "firebrick2")) (t (:weight bold :foreground "red"))) "Face for hi-lock mode." :group 'hi-lock-faces) @@ -216,8 +240,8 @@ hi-lock-interactive-patterns (define-obsolete-variable-alias 'hi-lock-face-history 'hi-lock-face-defaults "23.1") (defvar hi-lock-face-defaults - '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b" - "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb") + '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-magenta" "hi-cyan" + "hi-black-b" "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb") "Default faces for hi-lock interactive functions.") =20 (define-obsolete-variable-alias 'hi-lock-regexp-history