From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Date: Sat, 24 Nov 2018 23:29:15 +0200 Organization: LINKOV.NET Message-ID: <87a7lyi29o.fsf@mail.linkov.net> References: <9B715204-BE6D-4F02-B484-1EA9EDACE0EB@scratch.space> <87wope15gh.fsf@mail.linkov.net> <4D07BB6C-98A9-4EC2-BB37-097D5D753E53@scratch.space> <87wopbzeuy.fsf@mail.linkov.net> <87d0r04tmg.fsf@mail.linkov.net> <87sgzv747k.fsf@mail.linkov.net> <740AF1DA-7EDB-4310-8C6E-F7944D714513@scratch.space> <87sgzuca5o.fsf@mail.linkov.net> <87a7m0hi5t.fsf@mail.linkov.net> <837eh4gpjd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543096688 29067 195.159.176.226 (24 Nov 2018 21:58:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Nov 2018 21:58:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: van@scratch.space, 33398@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 24 22:58:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQfwB-0007P2-Dm for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Nov 2018 22:58:03 +0100 Original-Received: from localhost ([::1]:57859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQfyH-0001Ug-M9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Nov 2018 17:00:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQfyA-0001UP-2w for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:00:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQfy6-0008GV-Un for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:00:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQfy6-0008GN-RT for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gQfy6-0004hQ-KF for bug-gnu-emacs@gnu.org; Sat, 24 Nov 2018 17:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Nov 2018 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33398-submit@debbugs.gnu.org id=B33398.154309678017996 (code B ref 33398); Sat, 24 Nov 2018 22:00:02 +0000 Original-Received: (at 33398) by debbugs.gnu.org; 24 Nov 2018 21:59:40 +0000 Original-Received: from localhost ([127.0.0.1]:45892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQfxk-0004gC-D4 for submit@debbugs.gnu.org; Sat, 24 Nov 2018 16:59:40 -0500 Original-Received: from bisque.maple.relay.mailchannels.net ([23.83.214.18]:3505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQfxi-0004g3-AN for 33398@debbugs.gnu.org; Sat, 24 Nov 2018 16:59:39 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BFB684259F; Sat, 24 Nov 2018 21:59:36 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.26.166]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 88FB4426E4; Sat, 24 Nov 2018 21:59:36 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sat, 24 Nov 2018 21:59:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Share-Absorbed: 046df0390616a345_1543096776661_742643072 X-MC-Loop-Signature: 1543096776661:2216722771 X-MC-Ingress-Time: 1543096776661 Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 4FD5480570; Sat, 24 Nov 2018 13:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=7t4f8yXXRAhC7L/wFw9ZtlBEORk=; b= f02Pwr+q2rg6uM06vMD8hpNO3rw3pGw6l4Eyrp0MSubMyW+To2j7BeLS37y960eL SOd4j53RbkC2BwDfCp5gdJy/b/9VzFKPLIM6ODDQ8qNOe0EMRBZ1XpB2B+IrVyX4 RWHzl31L2tFv8AWCwnA/tt20u7HjjieVxK923GJM+wE= Original-Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 016068056A; Sat, 24 Nov 2018 13:59:33 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 In-Reply-To: <837eh4gpjd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Nov 2018 10:35:02 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddufedgudehiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtjedrvdegvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdejrddvgedvpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghlihiisehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152743 Archived-At: >> (defface hi-pink >> - '((((background dark)) (:background "pink" :foreground "black")) >> - (t (:background "pink"))) >> + '((((min-colors 88) (background dark)) >> + (:background "pink" :foreground "black")) >> + (((background dark)) (:background "red" :foreground "black")) >> + (((min-colors 88)) (:background "pink")) >> + (t (:background "red"))) >> "Face for hi-lock mode." >> :group 'hi-lock-faces) > > Thanks for working on this, but unfortunately changing the default > colors for Emacs faces is not that easy (which is why we do that only > very rarely). I understand that face changing is very sensitive area, so I don't insist on these changes if the result is worse. What I was trying to do is to add 2 more default colors: the current 4 is too small number of the default background colors, so adding 2 colors will at least cover all available 6 non-black-white colors on a 8-color TTY. > You cannot test your colors in just two points: 8-color TTY and > 256-color display (you probably used a GUI frame?). For starters, > there's the 16-color TTY, where according to my testing your changes > are for the worse. And I would also suggest to test with a 88-color > TTY. You need to test for both dark and light backgrounds. I tested these colors with TERM=xterm-256color where running emacs -Q -nw --color=8 -f list-colors-display displays a list of 8 colors, good. But running emacs -Q -nw --color=16 -f list-colors-display displays a list of 256 colors, the same number of colors properly displayed by emacs -Q -nw --color=256 -f list-colors-display Is this a bug in Emacs? Could you recommend a better way to test a 16-color palette on a TTY? > In general, if the automatic color translation in tty-colors.el does a > good job (you can test that by specifying the X color and watching the > result), it is best not to have a special definition for the > corresponding min-colors. So, for example, for the new hi-magenta and > hi-cyan faces you introduce, please see whether you really need the > definitions for less than 88 colors -- they will only be needed if the > automatic translation produces unpleasant results. For the new faces I copied the defface spec conditions from the existing faces hi-yellow and hi-green that have separate conditions for less than 88 colors. But we could drop unnecessary conditions here as well.