From: Noam Postavsky <npostavs@gmail.com>
To: "Gian Uberto Lauri" <saint@eng.it>
Cc: Robert Pluim <rpluim@gmail.com>, 32056@debbugs.gnu.org
Subject: bug#32056: Small patch
Date: Wed, 17 Apr 2019 20:13:56 -0400 [thread overview]
Message-ID: <87a7gow4or.fsf@gmail.com> (raw)
In-Reply-To: <23358.17085.759649.529099@mail.eng.it> (Gian Uberto Lauri's message of "Thu, 5 Jul 2018 18:09:33 +0200")
"Gian Uberto Lauri" <saint@eng.it> writes:
> +;; I am unsure if letting this customizable is a good idea.
> +(defvar ignore-file-size-list '() "A list of file for which the user is
> +not warned when the size exceeds `large-file-warning-threshold'." )
Hmm, this feels a bit unmotivated. I don't quite understand why the
user would choose only certain files to ignore the threshold instead of
just making the threshold higher.
> + ;; The user does not want to be bothered for
> + ;; these files (full path).
> + (not (let (rv)
> + (dolist (test-file-name ignore-file-size-list rv)
> + (setq rv
> + (or rv (string= filename test-file-name))))))
Though it might be more convenient to have a regexp rather than a
straight list.
> - (mapcar #'find-file-noselect files)))
> + (mapcar 'find-file-noselect files)))
No need for this. #' is fine.
prev parent reply other threads:[~2019-04-18 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 8:30 bug#32056: Small patch Gian Uberto Lauri
2018-07-05 10:22 ` Robert Pluim
2018-07-05 11:13 ` Noam Postavsky
2018-07-05 12:20 ` Gian Uberto Lauri
2018-07-05 14:00 ` Gian Uberto Lauri
2018-07-05 14:41 ` Robert Pluim
2018-07-05 16:09 ` Gian Uberto Lauri
2019-04-18 0:13 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7gow4or.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32056@debbugs.gnu.org \
--cc=rpluim@gmail.com \
--cc=saint@eng.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).