From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Kangas <stefan@marxist.se>
Cc: 35940@debbugs.gnu.org
Subject: bug#35940: [PATCH] bookmark.el: Remove support for renaming ancient "~/.emacs-bkmrks" file
Date: Thu, 30 May 2019 13:50:43 +0100 [thread overview]
Message-ID: <87a7f4t8bg.fsf@tcd.ie> (raw)
In-Reply-To: <CADwFkmn12TDJ-0W3G+UG2K6EOCnFuWAzKN+WHc4zw+dbPHvGbg@mail.gmail.com> (Stefan Kangas's message of "Thu, 30 May 2019 14:23:53 +0200")
Stefan Kangas <stefan@marxist.se> writes:
> Thank you for having a look.
Thank you for working on this.
> Basil L. Contovounesios <contovob@tcd.ie> writes:
>> Looks fine to me, but I suggest simultaneously making bookmark-file
>> (the old name of bookmark-default-file[1]) an obsolete varalias of
>> bookmark-default-file.
>
> Agreed, I've actually already submitted a separate patch for that:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35917
Right, I saw that just after I sent my previous message.
Both changes LGTM, so I'll push them in the coming week if there are no
other comments before then and no-one beats me to it.
But could you please first amend the commit messages to mention their
bug#numbers and list file names relative to the project root,
i.e. lisp/bookmark.el instead of bookmark.el?
Thanks,
--
Basil
next prev parent reply other threads:[~2019-05-30 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 1:23 bug#35940: [PATCH] bookmark.el: Remove support for renaming ancient "~/.emacs-bkmrks" file Stefan Kangas
2019-05-30 12:08 ` Basil L. Contovounesios
2019-05-30 12:23 ` Stefan Kangas
2019-05-30 12:50 ` Basil L. Contovounesios [this message]
2019-06-05 11:02 ` Stefan Kangas
2019-06-09 23:49 ` bug#35940: " Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7f4t8bg.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35940@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).