From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36591: 26.2; Term's pager seems broken Date: Thu, 25 Jul 2019 09:01:56 -0400 Message-ID: <87a7d2w9mj.fsf@gmail.com> References: <87lfwox3fi.fsf@gmail.com> <838ssops2u.fsf@gnu.org> <87imrsw5gj.fsf@gmail.com> <83y30no4hi.fsf@gnu.org> <87ftmvvsol.fsf@gmail.com> <875znqctzy.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="257378"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: abliss@gmail.com, 36591@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 25 15:03:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqdOr-0014k6-KX for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2019 15:03:13 +0200 Original-Received: from localhost ([::1]:59976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqdOo-0006vh-V9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2019 09:03:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42886) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqdOh-0006qb-Oy for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:03:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqdOg-00044Z-QV for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57956) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqdOg-00044R-MF for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqdOg-0003VU-GQ for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36591 X-GNU-PR-Package: emacs Original-Received: via spool by 36591-submit@debbugs.gnu.org id=B36591.156405972613396 (code B ref 36591); Thu, 25 Jul 2019 13:03:02 +0000 Original-Received: (at 36591) by debbugs.gnu.org; 25 Jul 2019 13:02:06 +0000 Original-Received: from localhost ([127.0.0.1]:38541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdNm-0003U0-Ew for submit@debbugs.gnu.org; Thu, 25 Jul 2019 09:02:06 -0400 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:44177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdNj-0003TO-Pe for 36591@debbugs.gnu.org; Thu, 25 Jul 2019 09:02:05 -0400 Original-Received: by mail-io1-f54.google.com with SMTP id s7so96890036iob.11 for <36591@debbugs.gnu.org>; Thu, 25 Jul 2019 06:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=phuB3cq6oDOKhhMCwx97+JSoSCp70LQPN4S245JtDKA=; b=mxlda7yg6fNvwV+Yd05y7nuBsqeVK6HIa+QSPAt9ksj0K/FR2s/qPYzTwUY5v9VTdk +g2IPtX6zSGz2Nord50HhyE/vg/mb/U6aVJeKzqKTywCYwG+jmkaTXsC/GnjyAZoB5dR vNWtz+JJG9mXPOsHFBSBsVhaTUXvwrrPDFYB3FTE4wXXx4MkHbTcinpAZbfTcT3qdzat Yyk3XMGc/+o6759V2RWw8HrLgxZ7fyTRsvYRW0LYnqK/2LUZ8N0xjZT03L/p6MfqnreE sCe7g07IqTYisNsIJ55GLurdYarnRLTwhiCAIx/AeAb+e+JOpkrV3/ZMkh4ix6pNUSJh EsDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=phuB3cq6oDOKhhMCwx97+JSoSCp70LQPN4S245JtDKA=; b=PA5mEtl5ulNcEDq2ysk4PRJXDxIMZBgZz9gtCtYswldUulHSJCL0VAcBrY9JTV668U 1NdGvTDkCQbiuXep1bGBMaqYqfE6zVtMkhk2ofbqHtORNipFBmenF+rlx9bLZ+p6I5Ta 7R1jWxxofkBtu9pN7lhdW1AIKDQWJtzpYz6BKN80kSQQJ/qKWYuFGdU4/VLkVYwpPBNU gyYoLBid5bh2+of+LVnGeWZ5wq1iRJKVolaA6QsiQpg3I7jXDriAAlOW1lR9KUwlLIsE nTR4H/PCGgfDVdJDe3dbsTeGUSL9ZM6AwrzBxtf3Cyl/mBul6tgoHN/olxhuVXQbIBr9 B+aw== X-Gm-Message-State: APjAAAWGTlOAVKqMBf1FB/L2yrmDxMDHDr+4KNRN1xct11DgfitqY1xf zxXAAUfUj5w1dicZmuhxKlCHU6Mv X-Google-Smtp-Source: APXvYqxxGGJBRD/BDva+XqPC0HlHbeoDgAG9j3+kqx8cQNc5SOLHYRxLXowX+5gveou8Ooy1v6B4kg== X-Received: by 2002:a02:bb08:: with SMTP id y8mr46404598jan.51.1564059717907; Thu, 25 Jul 2019 06:01:57 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id o7sm41834446ioo.81.2019.07.25.06.01.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jul 2019 06:01:57 -0700 (PDT) In-Reply-To: <875znqctzy.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Thu, 25 Jul 2019 12:02:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163704 Archived-At: Lars Ingebrigtsen writes: > the "we may not have the socket yet" refers to this bit: > > if (p->infd >= 0) > set_process_filter_masks (p); > > But it does indeed look like I was confused with filter/p->filter and > assumed they were the same. Do you think the reversed check in set_process_filter_masks could cause bugs for sockets too then?