unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: Paul Eggert <eggert@cs.ucla.edu>, 36940@debbugs.gnu.org
Subject: bug#36940: tests slowness and failure after recent Tramp changes
Date: Mon, 26 Aug 2019 21:47:37 +0200	[thread overview]
Message-ID: <87a7bvvhd2.fsf@gmx.de> (raw)
In-Reply-To: <CADwFkmnKTaZmNSrHK50F8jgCfnYi_a=m--GbpPajTeRUXeQ1Xg@mail.gmail.com> (Stefan Kangas's message of "Mon, 26 Aug 2019 19:46:33 +0200")

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Stefan Kangas <stefan@marxist.se> writes:

> Sorry, it's still failing.  I've attached the log.

Let's try this one. If it also fails, I will disable this part of the
test for macOS. Tramp works correctly, and the check is a minor one only.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1866 bytes --]

diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index 9930a2c9e1..3d5949b033 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -5288,18 +5288,26 @@ tramp--test-check-files
 		  (setenv "PS1")
 		  (with-temp-buffer
 		    (should (zerop (process-file "env" nil t nil)))
-		    (goto-char (point-min))
-		    (should
-		     (re-search-forward
-                      ;; We must use proper encoding on macOS.  See
-                      ;; Bug#36940.
-                      (funcall
-	               (if (eq coding-system-for-read 'utf-8-hfs)
-                           'ucs-normalize-HFS-NFD-string 'identity)
-		       (format
-		        "^%s=%s$"
-		        (regexp-quote envvar)
-		        (regexp-quote (getenv envvar)))))))))))
+                    (tramp--test-message
+                     "coding-sytem: `%s' `%s'"
+                     coding-system-for-read coding-system-for-write )
+                    (tramp--test-message "search: `%s'" (getenv envvar))
+                    ;; We must use proper encoding on macOS.  See
+                    ;; Bug#36940.
+                    (let ((system-type 'gnu/linux)
+                          (coding-system-for-read 'no-conversion)
+                          (coding-system-for-write 'no-conversion))
+                      (tramp--test-message
+                       "search: `%s'"
+                       (ucs-normalize-HFS-NFD-string (getenv envvar)))
+                      (tramp--test-message "buffer: `%s'" (buffer-string))
+		      (goto-char (point-min))
+		      (should
+		       (re-search-forward
+		        (format
+		         "^%s=%s$"
+		         (regexp-quote envvar)
+		         (regexp-quote (getenv envvar)))))))))))

 	;; Cleanup.
 	(ignore-errors (delete-directory tmp-name1 'recursive))

[-- Attachment #3: Type: text/plain, Size: 57 bytes --]


> Best regards,
> Stefan Kangas

Best regards, Michael.

  reply	other threads:[~2019-08-26 19:47 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06  0:28 bug#36940: tests slowness and failure after recent Tramp changes Paul Eggert
2019-08-06 12:59 ` Michael Albinus
2019-08-06 16:13   ` Paul Eggert
2019-08-06 19:16     ` Michael Albinus
2019-08-06 19:54     ` Michael Albinus
2019-08-06 23:27       ` Paul Eggert
2019-08-07 15:20         ` Michael Albinus
2019-08-07 19:36           ` Paul Eggert
2019-08-08 14:14             ` Michael Albinus
2019-08-07 21:42           ` Glenn Morris
2019-08-08 13:52             ` Michael Albinus
2019-08-10  1:39               ` Paul Eggert
2019-08-10  9:43                 ` Michael Albinus
2019-08-10 20:24                   ` Paul Eggert
2019-08-11 10:12                     ` Michael Albinus
2019-08-14 10:31                       ` Michael Albinus
2019-08-15  4:26                         ` Paul Eggert
2019-08-24  1:51                         ` Stefan Kangas
2019-08-24  8:08                           ` Michael Albinus
2019-08-24 12:51                             ` Stefan Kangas
     [not found]                               ` <CADwFkmnZ1D-t3BchTSuUrkbkOpKG=yCH9c1ZJbkyGr9mUZrAUg@mail.gmail.com>
2019-08-25  9:27                                 ` Michael Albinus
2019-08-25  9:51                                   ` Eli Zaretskii
2019-08-25 10:07                                     ` Eli Zaretskii
2019-08-25 11:26                                       ` Michael Albinus
2019-08-25 11:39                                         ` Eli Zaretskii
2019-08-25 11:46                                           ` Michael Albinus
2019-08-25 11:58                                             ` Eli Zaretskii
2019-08-26  9:22                                               ` Michael Albinus
2019-08-26  9:59                                                 ` Eli Zaretskii
2019-08-26 11:47                                                   ` Michael Albinus
2019-08-26 12:54                                                     ` Stefan Kangas
2019-08-26 14:19                                                       ` Michael Albinus
2019-08-26 14:36                                                         ` Stefan Kangas
2019-08-26 15:09                                                           ` Michael Albinus
2019-08-26 15:46                                                             ` Stefan Kangas
2019-08-26 16:43                                                               ` Michael Albinus
2019-08-26 17:46                                                                 ` Stefan Kangas
2019-08-26 19:47                                                                   ` Michael Albinus [this message]
2019-08-27 16:34                                                                     ` Stefan Kangas
2019-08-27 16:56                                                                       ` Michael Albinus
2019-08-28  0:23                                                                         ` Stefan Kangas
2019-08-25 11:28                                     ` Michael Albinus
2019-08-25 11:48                             ` Michael Albinus
2019-08-25 15:39                               ` Paul Eggert
2019-08-25 16:34                                 ` Michael Albinus
2019-08-25 20:36                                   ` Paul Eggert
2019-08-26  8:44                                     ` Michael Albinus
2019-08-27  2:17                                       ` Paul Eggert
2019-08-27 11:03                             ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7bvvhd2.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=36940@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).