From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alexander Miller <alexanderm@web.de>
Cc: 28599@debbugs.gnu.org
Subject: bug#28599: 26.0.50; font-lock-ensure changes the face of text buttons
Date: Wed, 30 Oct 2019 19:48:18 +0100 [thread overview]
Message-ID: <87a79iqdcd.fsf@gnus.org> (raw)
In-Reply-To: <89bbbfb8-efe5-edca-a571-ca73267cb498@web.de> (Alexander Miller's message of "Mon, 25 Sep 2017 21:47:53 +0200")
Alexander Miller <alexanderm@web.de> writes:
> Steps to reproduce:
>
> * emacs -q
> * switch to a text-mode buffer
> * Run (insert-text-button "AAAAAAAAAAA" 'face 'font-lock-constant-face)
> * Run (font-lock-ensure)
>
> The button's face will now have changed from font-lock-constant to button.
> This only happens once, a second call to font-lock-ensure makes no such
> changes.
> Overlay buttons don't seem to be affected.
>
> I also tested this on a self-compiled emacs 25.2.1, with the same result.
I'm unable to reproduce this exactly -- when I try this in Emacs 27, the
face property is just cleared, and no new face is applied. And it
happens on all calls to font-lock-ensure.
This happens because that function calls,
font-lock-default-fontify-region, which calls
font-lock-default-unfontify-region is called, and it just does
(defun font-lock-default-unfontify-region (beg end)
"Unfontify the text between BEG and END.
This function is the default `font-lock-unfontify-region-function'."
(remove-list-of-text-properties
beg end (append
font-lock-extra-managed-props
(if font-lock-syntactic-keywords
'(syntax-table face font-lock-multiline)
'(face font-lock-multiline)))))
So if you want to have both your own faces and use font-lock, too, you
have to use font-lock-face instead of face, according to "Precalculated
Fontification".
So there doesn't seem to be a bug here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-10-30 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 19:47 bug#28599: 26.0.50; font-lock-ensure changes the face of text buttons Alexander Miller
2019-10-30 18:48 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a79iqdcd.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=28599@debbugs.gnu.org \
--cc=alexanderm@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).