From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#24472: - a workaround/fix for the menubar crashes on macOS Date: Sat, 02 May 2020 14:15:19 +0200 Message-ID: <87a72qy1m0.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="126834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 24472@debbugs.gnu.org To: Marc Herbert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 02 14:16:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUr4O-000WvI-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 May 2020 14:16:36 +0200 Original-Received: from localhost ([::1]:37052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUr4N-0004nK-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 May 2020 08:16:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUr3r-0004n8-Lx for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 08:16:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUr3r-0002gw-3Q for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 08:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUr3q-0002fJ-Lm for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 08:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUr3q-0000nu-G9 for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 08:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24472-submit@debbugs.gnu.org id=B24472.15884217313048 (code B ref 24472); Sat, 02 May 2020 12:16:02 +0000 Original-Received: (at 24472) by debbugs.gnu.org; 2 May 2020 12:15:31 +0000 Original-Received: from localhost ([127.0.0.1]:51475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUr3K-0000n6-Uz for submit@debbugs.gnu.org; Sat, 02 May 2020 08:15:31 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:50503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUr3I-0000ms-NB for 24472@debbugs.gnu.org; Sat, 02 May 2020 08:15:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588421721; bh=Gg2q/aeIzLzbwxZly89SQwAUCvHD4IMv92bKkC7AAfI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=HCIzRnms5ClTS8XHouGwSd0mh+rjksLkWDHuKvGz34GQTms+6IbfvU1WgKkfMLCLr CLicw6rFbTdK5yTyQYi2btLARsMN4nVwPfrvPxtDurrUvgdS5UQ9s9hnpo5Z4XlvwA aRCcNqVYN381jdks0tzvj4LtJpwWuuzm8J3b5r+E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.112.148]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MGQj7-1jMru00xcT-00Gt8s; Sat, 02 May 2020 14:15:21 +0200 In-Reply-To: (Marc Herbert's message of "Fri, 1 May 2020 01:47:19 -0700") X-Provags-ID: V03:K1:IGUK7lP632pbaPPGdQmGH5HpOOBBnKhaw5/FziDZudYo4VZHhnM bf76ZuHBrMWUeMxtV7ErNDjkZThlF7MvLquq4Lym07xUWSMeZdmhFZuo+/+qz7O+YKI6WHR 2pbD4zdDq5Q0ZRYEfwwHxa5OuNTRobMn+IlGlE+rmrXS212z5vU6m2o0BH9PW72yt4ZjqDO yv2rIbAXV6ePfIiVPi2nw== X-UI-Out-Filterresults: notjunk:1;V03:K0:f6D1K8FUa6Q=:DPir1oFBnYVdSAmVQhrJ4m 71xSrxGQnvvwu625IptzMrEbGLUf5OF00CIGGF2oKTmFJ6MjK1WxSeX0qVDzW5YWdLTOjjLtZ waSDxdRmFQKv8WAcsFl3vOYmJDr+Yu7AsrZH6659ftYHohiKgkI9Add3yrJoY5S3uQJmiTJpc 64VdSyRf40G1QFfj//7e7NcWCZqDkcpyksDGDIcuSL1tTopDtAcwNocxYjcwVh/O9Ius422PO kK8qFlJgfO0Oug3A9PiYPAhdfApLrfHMyMwBIsefLGXo7J3I/nZCAmQ9dZhr17gr7+NHbsWMw EtnTyl3ozQYcHyodcpsswBRoTMT3OJiCH2ViqATieXnYOpJMYR0JkHrTzybh7Ow8p7QuOhJ6L CV6DS9gufVPZYPyxQ2sdTYOdyrf9lZj528gdL8i/P6aQE+w99QEs0C5AgCbJFwE9E+ztgzt6Y HAYpa+j0FBhiklUw28evlTXMJDmabAYHb8Mj3/8Bh7rIIbCxd7d5uLUK1mjQMjmhQRYMSEd6M F7X3Oyyy85jaDrTQ1fjBS95t64g0e1woQ6sddBCCMAAyn67cIhQlto1TtsJyKgEzT0bBYIDwm /Vk4vGfHJquZrvWVs7rKaYxQCHwuqGmdXWH/9gOm15r9AAfUWU2wjD/esG3kM+HmeH7bdJgFk zaGHNeh0UCOS0TkHhK8+PsuCFGlDcycUYNYwN6fAP1ZzSg2gZ/kqKW664yALAl+Cj5o5sCB6d Io6CRNHjA/2pVwkbzXhsTIgHYxbK1O5gTUUC/KW0I4qju3G3IEU3Jd1M+Tm+4xa/0FvWO4Cr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179499 Archived-At: Marc Herbert writes: Hi Marc, > I leveraged the milder symptoms in 26.1 to debug the issue and found a > workaround/fix. I then upgraded to 26.3 and ta-da: the crashes are > gone! > > The root cause is in menu-bar.el which defines the revert-buffer item like this: > > '(menu-item "Revert Buffer" revert-buffer > :enable (or (blah) (blah) > (and buffer-file-number > (or (buffer-modified-p) > (not (verify-visited-file-modtime > (current-buffer)))))) > > This greys out the "Revert Buffer" menu item when (among others) no > one modified the file outside Emacs. > > verify-visited-file-modtime calls > tramp-sh-handle-verify-visited-file-modtime that temporarily hardcodes > remote-file-name-inhibit-cache to 't that causes the network accesses > that cause the delays and/or crashes. Excellent analysis! > After a few other attempts, my final workaround is dead simple: remove > the "Revert Buffer" item from the menu by adding this one line to your > .emacs file: > > (define-key global-map [menu-bar file revert-buffer] nil) > > Enjoy. I think it's better than a "workaround" actually, it's almost a > "feature" that I'm going to keep that in my .emacs file permanently > because trying to use the network every time you click the menubar is > just... silly? Isn't this too heavy? Wouldn't it be sufficient to avoid the `verify-visited-file-modtime' call in case the buffer is visiting a remote file? Something like (and buffer-file-number (or (buffer-modified-p) (file-remote-p default-directory) (not (verify-visited-file-modtime (current-buffer)))))) > I also tried to hack menu-bar.el directly but any change I made to it > was completely ignored. Anyone knows why? Hmm. Have you recompiled the whole Emacs after your change? Maybe menu-bar.elc is dumped into Emacs? Best regards, Michael.