From: Karl Fogel <kfogel@red-bean.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Matthias Meulien <orontee@gmail.com>,
Stefan Kangas <stefan@marxist.se>,
39293@debbugs.gnu.org
Subject: bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode'
Date: Tue, 26 May 2020 15:38:16 -0500 [thread overview]
Message-ID: <87a71ue8jr.fsf@red-bean.com> (raw)
In-Reply-To: <1fd3ebe3-e447-43af-8086-32a98febe475@default> (Drew Adams's message of "Tue, 26 May 2020 13:02:04 -0700 (PDT)")
On 26 May 2020, Drew Adams wrote:
>Sorry, I really don't have the time to deal with
>this now.
>
>Bookmark+ has lots of added features, and many
>have to do with the bookmark-list display. If
>you're interested in that, please see its doc.
>
>Maybe at some point later I'll have the time and
>will to tick off things in Bookmark+ that t-l-mode
>interferes with or prohibits.
>
>I think at this point you'll just have to take my
>word for it (or not) that it would be far too much
>work, too risky, and for no benefit, for me to try
>to rewrite such features to adapt to t-l-mode.
Okay, fair enough -- I understand about limited time.
>And I'm pretty sure that some things would need to
>be sacrificed. In my experience just with `apu.el'
>(which uses t-l-mode) I ran into limitations that
>I had to work around (no, I don't recall what they
>were).
>
>[Can a t-l-mode buffer even have a title (not just
>column headings)? With Bookmark+ the listing
>reflects the current sorting and filterings, and
>the title at the top tells you what the listing is
>about.]
>
>I'm sorry to say it, but I won't try, for Bookmark+.
>I don't have the time to waste on that. Sorry.
>
>Do what you think you have to do. I'll do what I
>have to do, given my limited resources. I expect
>I'll likely just incorporate the former bookmark.el
>code that Bookmark+ currently takes for granted.
Well, I don't think we "have to" convert bookmark.el to use t-l-mode at all.
>FWIW, I also don't think that bookmark.el's list
>of bookmarks is a great candidate for t-l-mode.
>I don't think it adds anything important for such
>a simple list with 2-3 columns. As I said in my
>Jan 26 mail, sorting by those columns (which is
>really all that t-l-mode offers here) is not so
>helpful. (OK, it has some use.)
>
>Maybe consider ibuffer.el instead? As I said
>earlier, trying ibuffer, which offers a bit more
>than a rudimentary listing, might point to some
>t-l-mode limitations or complications. And if
>it doesn't then so much the better. ;-)
Well, I mean, bookmark.el seems to be working fine the way it is right now, without t-l-mode nor ibuffer. So I'm not sure the proposed change is warranted.
Stefan, is there a strong motivation here, other than the obvious attractions of re-using code and avoiding multiple implementations of similar functionality?
(If we decide not to make the change, then we should add a comment to bookmark.el pointing to this bug-ticket discussion and explaining *why* we have left the code as-is.)
>To be clear, I don't think I said that anything
>would be limited or broken in _bookmark.el_ by
>using t-l-mode. Potential uses of its features,
>and existing uses by 3rd-party libraries (e.g.
>Bookmark+), could be limited or broken. But I
>doubt that anything bookmark.el offers out of
>the box would be affected much, if at all.
>(bookmark.el could probably drop a good deal of
>its code without breaking anything that people
>use much).
Agreed; that's what I understood you to be saying.
Best regards,
-Karl
next prev parent reply other threads:[~2020-05-26 20:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 3:13 bug#39293: [PATCH] Base bookmark-bmenu-mode on 'tabulated-list-mode' Stefan Kangas
2020-01-26 18:05 ` Drew Adams
2020-01-26 19:33 ` Stefan Kangas
2020-01-26 22:35 ` Drew Adams
2020-04-26 14:59 ` Stefan Kangas
2020-05-23 21:18 ` Stefan Kangas
2020-05-23 21:31 ` Drew Adams
2020-05-23 21:44 ` Drew Adams
2020-05-23 22:16 ` Stefan Kangas
2020-05-23 20:31 ` Matthias Meulien
2020-05-23 21:01 ` Stefan Kangas
2020-05-23 21:26 ` Drew Adams
2020-05-26 17:43 ` Karl Fogel
2020-05-26 20:02 ` Drew Adams
2020-05-26 20:38 ` Karl Fogel [this message]
2020-05-26 21:41 ` Drew Adams
2020-05-27 9:50 ` Stefan Kangas
2020-06-12 11:55 ` Basil L. Contovounesios
2020-06-12 18:03 ` Drew Adams
2020-06-12 21:40 ` Basil L. Contovounesios
2020-06-13 0:05 ` Drew Adams
2020-06-13 12:17 ` Basil L. Contovounesios
2020-08-18 15:24 ` Lars Ingebrigtsen
2020-10-13 3:41 ` Lars Ingebrigtsen
2020-10-13 9:14 ` Stefan Kangas
2020-10-14 3:42 ` Lars Ingebrigtsen
2020-10-17 15:58 ` Stefan Kangas
2020-10-18 8:17 ` Lars Ingebrigtsen
2020-10-13 15:36 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a71ue8jr.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=39293@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=orontee@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).