From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41438: [PATCH] Allow windmove keys to be bound without prefix or modifiers Date: Fri, 07 Aug 2020 02:43:03 +0300 Organization: LINKOV.NET Message-ID: <87a6z78gqw.fsf@mail.linkov.net> References: <87pn84p1hj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40368"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41438@debbugs.gnu.org, larsi@gnus.org To: "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 07 02:53:26 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3qdS-000APD-18 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Aug 2020 02:53:26 +0200 Original-Received: from localhost ([::1]:47406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3qdR-0001rx-2D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Aug 2020 20:53:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3qd4-0001Tx-Hn for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 20:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3qd4-00034e-8w for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 20:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3qd4-0000eL-7t for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 20:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Aug 2020 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41438-submit@debbugs.gnu.org id=B41438.15967615772456 (code B ref 41438); Fri, 07 Aug 2020 00:53:02 +0000 Original-Received: (at 41438) by debbugs.gnu.org; 7 Aug 2020 00:52:57 +0000 Original-Received: from localhost ([127.0.0.1]:55172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3qcz-0000dY-78 for submit@debbugs.gnu.org; Thu, 06 Aug 2020 20:52:57 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3qcw-0000d5-7q for 41438@debbugs.gnu.org; Thu, 06 Aug 2020 20:52:56 -0400 X-Originating-IP: 91.129.102.47 Original-Received: from mail.gandi.net (m91-129-102-47.cust.tele2.ee [91.129.102.47]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 923291C0002; Fri, 7 Aug 2020 00:52:46 +0000 (UTC) In-Reply-To: <87pn84p1hj.fsf@posteo.net> (Philip K.'s message of "Thu, 06 Aug 2020 11:28:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184219 Archived-At: >> (I see there were some unfinished parts in your previous patch). > > It's been a while since I submitted it, so I had to re-read the thread, > but I'm not quite sure what the "unfinished" parts were, aside from the > missing autoload cookies. Sorry if I missed something :/ I don't know, my impression seems to suggest the first version was not completely tested, for example, windmove-modifiers defcustom called windmove-swap-states-default-keybindings, not windmove-default-keybindings. But maybe you already fixed this. > Also, the second patch (the one with the user options) depended on the > previous one in this thread[0], that introduced the "none" prefix. Is > that fine, or should I just merge both patches into one. This is perfectly fine - better to commit two separate patches.