From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Sat, 15 Aug 2020 14:37:26 +0200 Message-ID: <87a6ywxeyh.fsf@gnus.org> References: <87y2y5lfnb.fsf@1e0.co.uk> <83eezxatsv.fsf@gnu.org> <87tv8slb6w.fsf@mattleach.net> <83a7aka1q5.fsf@gnu.org> <87sgocfh8c.fsf@mattleach.net> <83y2y48f8u.fsf@gnu.org> <87o8z0few1.fsf@mattleach.net> <83sgob98zk.fsf@gnu.org> <9ipnjdemzv.fsf@fencepost.gnu.org> <878sq0jqi6.fsf@mattleach.net> <87o8uyrlja.fsf@marxist.se> <83pnfevsbv.fsf@gnu.org> <7nd0bd8w1e.fsf@fencepost.gnu.org> <83eevrv6hk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 37564@debbugs.gnu.org, stefan@marxist.se, matthew@mattleach.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 15 14:38:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6vRr-0004iI-MO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 14:38:11 +0200 Original-Received: from localhost ([::1]:48848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6vRq-0002qV-Pc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 08:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6vRi-0002qG-5W for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 08:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6vRh-0004Yd-Rh for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 08:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6vRh-0008Vm-PU for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 08:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 12:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.159749506832681 (code B ref 37564); Sat, 15 Aug 2020 12:38:01 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 15 Aug 2020 12:37:48 +0000 Original-Received: from localhost ([127.0.0.1]:54419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6vRT-0008V3-VY for submit@debbugs.gnu.org; Sat, 15 Aug 2020 08:37:48 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6vRS-0008Ul-5p for 37564@debbugs.gnu.org; Sat, 15 Aug 2020 08:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Oc/4uE6kqiCFSEwYJHVcWXCr2GgjjGX9KNaR2Z89TeU=; b=hvYAmOGApMm1/OWSUCxs6hyHgQ vZk6DCUw9jOdO2lw99oHh2Yx2A6z3L7sAA0sEntC/gDO3BkdvbiUz5lHimfDY7yI/CY1p1L8VV/dP YS+Ym0GvrDg8aJR/mSOB39qMej/Sidkk/KPNllbk+2YvEfKFdcgIHSe9Kr3GQLdETw9g=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6vR9-0007YM-R6; Sat, 15 Aug 2020 14:37:39 +0200 X-Now-Playing: Archie Shepp's _The Cry Of My People_: "A Prayer" In-Reply-To: <83eevrv6hk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Jan 2020 17:46:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185223 Archived-At: Eli Zaretskii writes: >> PS for an example of the effect, one can use some of the programs in >> the ncurses-examples from >> https://invisible-island.net/ncurses/ncurses-examples.html >> >> eg "worm". > > I understand that applications based on ncurses are affected, but what > about those which aren't based on ncurses? I think the rough consensus here was that adding LINES/COLUMNS is usually the wrong thing to do, but Eli worries that this might break something. So I've applied Matthew's patch, but also added a defcustom to control this. I've defaulted the variable to "don't add the variables", but if this leads to problems during the Emacs 28.1 cycle, we can flip it to "on" later. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no