unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 42865@debbugs.gnu.org, Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#42865: 28.0.50; Add new 'copy-region-quietly' defcustom
Date: Thu, 20 Aug 2020 03:52:39 +0300	[thread overview]
Message-ID: <87a6yqc874.fsf@mail.linkov.net> (raw)
In-Reply-To: <87eeo37x1f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 19 Aug 2020 12:25:00 +0200")

>> Regarding a new option to disable such messages at all, it seems this
>> is a more general question because AFAIR, in the past, users asked for
>> a way to disable messages for many other commands, such as "Wrote ..."
>> of 'save-buffer', etc.
>>
>> Maybe there should be a new feature allowing to disable messages selectively
>> for different commands?  Maybe just by putting a symbol property on the
>> command symbol.
>
> Many commands can issue different messages, while it's normally just the
> specific "everything went well" thing users want to disable.  So I think
> that may be confusing, interface wise?
>
> But perhaps not?  If the symbol wasn't `silent' but instead
> `no-normal-message' or something, then that could be used to disable any
> messaging in the command on the "happy path".

Generally, different error levels should specify the message priority
(debug, info, warning, error).  I'm not quite sure what functions
correspond to these levels in Emacs.  Definitely, errors should be raised
by the function 'error', but it seems most messages are informational.

Anyway, here is a patch that allows disabling messages for particular
commands with e.g.

  (put 'kill-ring-save 'inhibit-message t)

diff --git a/src/xdisp.c b/src/xdisp.c
index ad03ac4605..9cbbec61f6 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -10984,7 +10984,7 @@ message3 (Lisp_Object m)
       message_dolog (buffer, nbytes, true, multibyte);
       SAFE_FREE ();
     }
-  if (! inhibit_message)
+  if (! inhibit_message && NILP (Fget (Vthis_command, Qinhibit_message)))
     message3_nolog (m);
 }
 
@@ -34348,6 +34353,7 @@ syms_of_xdisp (void)
 
   DEFSYM (Qredisplay_internal_xC_functionx, "redisplay_internal (C function)");
 
+  DEFSYM (Qinhibit_message, "inhibit-message");
   DEFVAR_BOOL("inhibit-message", inhibit_message,
               doc:  /* Non-nil means calls to `message' are not displayed.
 They are still logged to the *Messages* buffer.







  reply	other threads:[~2020-08-20  0:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 17:38 bug#42865: 28.0.50; Add new 'copy-region-quietly' defcustom Sean Whitton
2020-08-18 13:37 ` Lars Ingebrigtsen
2020-08-19  1:16   ` Juri Linkov
2020-08-19 10:25     ` Lars Ingebrigtsen
2020-08-20  0:52       ` Juri Linkov [this message]
2020-08-20 13:01         ` Lars Ingebrigtsen
2020-08-20 23:19           ` Juri Linkov
2020-08-21 11:28             ` Lars Ingebrigtsen
2020-08-23 18:39               ` Juri Linkov
2020-08-24 13:14                 ` Lars Ingebrigtsen
2020-08-24 13:26                   ` Stefan Kangas
2020-08-24 14:00                     ` Lars Ingebrigtsen
2020-08-24 18:38                   ` Juri Linkov
2020-08-24 19:34                     ` Stefan Kangas
2020-08-25 18:40                       ` Juri Linkov
2020-08-26  0:36                         ` Stefan Kangas
2020-08-27 19:08                           ` Juri Linkov
2020-11-15 20:40                           ` Juri Linkov
2020-08-20  0:55       ` Juri Linkov
2020-08-20 13:05         ` Lars Ingebrigtsen
2020-11-15 20:33       ` Juri Linkov
2020-08-19 16:36     ` Sean Whitton
2020-08-19 16:32   ` Sean Whitton
2020-08-19 16:49     ` Lars Ingebrigtsen
2020-09-10 16:05       ` Sean Whitton
2020-09-11 11:57         ` Lars Ingebrigtsen
2020-09-12 21:22           ` Sean Whitton
2020-09-13 13:09             ` Lars Ingebrigtsen
2021-06-06  9:20               ` Lars Ingebrigtsen
2021-06-28  2:02                 ` Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6yqc874.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=42865@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=spwhitton@spwhitton.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).