unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 13072@debbugs.gnu.org
Subject: bug#13072: 24.3.50; Fancy Diary display fontification failures
Date: Tue, 25 Aug 2020 20:02:04 +0200	[thread overview]
Message-ID: <87a6yili3n.fsf@gmx.net> (raw)
In-Reply-To: <877dtqolpt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 22 Aug 2020 15:26:38 +0200")

On Sat, 22 Aug 2020 15:26:38 +0200 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> I don't know, but a first rough implementation of your suggestion seems
>> promising: with the patch below, when using either of the above values
>> of calendar-date-display-form, the date strings are fontified.  A
>> complete fix should go through the code carefully, checking for possible
>> corner cases.  Glenn Morris probably knows best if such an approach is
>> worth pursuing.
>
> [...]
>
>> -              (insert (if (bobp) "" ?\n) (calendar-date-string date))
>> +              (insert (if (bobp) "" ?\n)
>> +                      (propertize (calendar-date-string date) 'face 'diary))
>
> Makes sense to me.  And we could then probably remove
> diary-fancy-date-pattern.

That sounds like a good simplification of the code, but I think Glenn
should chime in before any such change is made.

Steve Berman





  reply	other threads:[~2020-08-25 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04  0:01 bug#13072: 24.3.50; Fancy Diary display fontification failures Stephen Berman
2020-08-21 12:35 ` Lars Ingebrigtsen
2020-08-21 14:46   ` Stephen Berman
2020-08-22 13:26     ` Lars Ingebrigtsen
2020-08-25 18:02       ` Stephen Berman [this message]
2020-08-25 19:02         ` Lars Ingebrigtsen
2020-10-13  2:11         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6yili3n.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=13072@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).