From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#6870: Make vc-root-diff work in more modes Date: Tue, 25 Aug 2020 15:38:42 +0200 Message-ID: <87a6yi976l.fsf@gnus.org> References: <19561.60443.364109.899857@rgr.rgrjr.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2997"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 6870@debbugs.gnu.org To: rogers-emacs@rgrjr.dyndns.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 25 15:39:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAZAa-0000e2-4A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 15:39:24 +0200 Original-Received: from localhost ([::1]:60324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAZAZ-0008KU-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 09:39:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAZAE-0007pZ-Ub for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAZAE-0006TV-Le for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAZAE-0007pO-Ji for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6870 X-GNU-PR-Package: emacs Original-Received: via spool by 6870-submit@debbugs.gnu.org id=B6870.159836274030050 (code B ref 6870); Tue, 25 Aug 2020 13:39:02 +0000 Original-Received: (at 6870) by debbugs.gnu.org; 25 Aug 2020 13:39:00 +0000 Original-Received: from localhost ([127.0.0.1]:60777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZAC-0007oW-3G for submit@debbugs.gnu.org; Tue, 25 Aug 2020 09:39:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZA4-0007nh-J9 for 6870@debbugs.gnu.org; Tue, 25 Aug 2020 09:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kf0OHUUXug3cA2HQaD41m34CBKigfYhIWXc4ffAr92g=; b=LLjoBh0BTWA7xRRMknVl1Ymz0m Ll9GEgQ+XzUaGMZ8PoAn/2SMQ2srQ0hikf4tCkzRqeR/UxLjwY87HX51dYM1UxACArswwIzVAFnAJ 27yY2YWOqalAxdPEcsOYXx0zzzcasfJUG0Rt2LK0jlkKeAydTtr+FSCAeYSAk9nsHhVA=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAZ9v-00068V-M6; Tue, 25 Aug 2020 15:38:46 +0200 X-Now-Playing: DACM's =?UTF-8?Q?=5FSt=C3=83=C2=A9r=C3=83=C2=A9otypie=5F:?= "LN End" In-Reply-To: <19561.60443.364109.899857@rgr.rgrjr.com> (rogers-emacs@rgrjr.dyndns.org's message of "Mon, 16 Aug 2010 21:55:39 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186287 Archived-At: rogers-emacs@rgrjr.dyndns.org writes: > It makes sense to me that vc-root-diff uses "(vc-responsible-backend > default-directory)" when in a dired-mode buffer. But since vc-root-diff > is not at all about the current buffer, why not also make that the > default for shell-mode, diff-mode, or any of the other modes for > non-version-controlled buffers that may be generated in a working copy? [...] > - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory)) > - (vc-mode (vc-backend buffer-file-name)))) > + (vc-mode (vc-backend buffer-file-name)) > + (t (vc-responsible-backend default-directory)))) This has been extended somewhat over the years: (defun vc-deduce-backend () (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) ((derived-mode-p 'log-view-mode) log-view-vc-backend) ((derived-mode-p 'log-edit-mode) log-edit-vc-backend) ((derived-mode-p 'diff-mode) diff-vc-backend) ;; Maybe we could even use comint-mode rather than shell-mode? ((derived-mode-p 'dired-mode 'shell-mode 'compilation-mode) (ignore-errors (vc-responsible-backend default-directory))) (vc-mode (vc-backend buffer-file-name)))) So we still don't do this in all buffers, but since there's some issues with that, I think this works well now. So I'm closing this bug report. If there's more to be done here, respond to the debbugs address and we'll reopen the report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no