From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 24585@debbugs.gnu.org, Leo Liu <sdl.web@gmail.com>
Subject: bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer
Date: Sat, 05 Sep 2020 14:32:57 +0200 [thread overview]
Message-ID: <87a6y4769y.fsf@gnus.org> (raw)
In-Reply-To: <jwvft7xfsvv.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Fri, 04 Sep 2020 11:45:31 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> This was too long ago and got moved to write-only swap space, and
>>> I haven't had time to dig into it now to recover the lost context, but
>>> I can see a potential case where it makes a difference, which is if the
>>> timer is set multiple times before it gets a chance to be run: with the
>>> new code only one of the timers will actually be executed.
>>
>> That's true; I didn't think about that. But wouldn't a more obvious fix
>> be to cancel the previous timer, if there's already a timer in-flight?
>
> Could be. I don't even know if this effect was the one intended in
> any case.
Me neither. I've now applied the
+ (when (buffer-live-p buffer)
part of the patch, but not the rest. Perhaps Leo can chime in with that
the patch was trying to achieve.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-05 12:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 4:56 bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer Leo Liu
2016-10-02 20:35 ` Stefan Monnier
2016-10-03 3:01 ` Leo Liu
2016-10-03 13:24 ` Stefan Monnier
2016-10-03 15:22 ` Leo Liu
2016-10-03 18:45 ` Stefan Monnier
2016-10-04 13:08 ` Leo Liu
2016-10-04 16:18 ` Stefan Monnier
2016-10-05 7:39 ` Leo Liu
2016-10-05 10:25 ` Eli Zaretskii
2016-10-06 16:12 ` Leo Liu
2016-10-06 18:10 ` Stefan Monnier
2016-10-06 18:31 ` Leo Liu
2016-10-06 18:37 ` Eli Zaretskii
2016-10-07 1:21 ` Leo Liu
2016-10-07 2:27 ` Leo Liu
2016-10-07 8:02 ` Eli Zaretskii
2016-10-07 12:46 ` Stefan Monnier
2016-10-07 17:07 ` Leo Liu
2016-10-07 18:10 ` Stefan Monnier
2016-10-08 18:10 ` Leo Liu
2020-09-04 12:47 ` Lars Ingebrigtsen
2020-09-04 14:29 ` Stefan Monnier
2020-09-04 15:02 ` Lars Ingebrigtsen
2020-09-04 15:45 ` Stefan Monnier
2020-09-05 12:32 ` Lars Ingebrigtsen [this message]
2020-10-07 3:30 ` Lars Ingebrigtsen
2016-10-07 7:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6y4769y.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24585@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).