From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Date: Mon, 07 Sep 2020 12:30:12 +0200 Message-ID: <87a6y1angr.fsf@gnus.org> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3262"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 12:31:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFEQb-0000m1-7K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 12:31:13 +0200 Original-Received: from localhost ([::1]:52996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFEQa-0003tr-7i for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 06:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFEQR-0003pT-9L for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 06:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFEQQ-0003UN-Vp for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 06:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFEQQ-0000aX-Rm for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 06:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Sep 2020 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43120 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 43120-submit@debbugs.gnu.org id=B43120.159947462532520 (code B ref 43120); Mon, 07 Sep 2020 10:31:02 +0000 Original-Received: (at 43120) by debbugs.gnu.org; 7 Sep 2020 10:30:25 +0000 Original-Received: from localhost ([127.0.0.1]:48187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEPp-0008S1-6G for submit@debbugs.gnu.org; Mon, 07 Sep 2020 06:30:25 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFEPm-0008Jb-ED; Mon, 07 Sep 2020 06:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6FZFhH5n9tyPjo0DIjFSj+NNJQ0jNUR/5DgCeFsd14o=; b=VmCCs9gm+cAkRsKCE+HK44Kkcg XaHL4wKEjOVB/c1qKuZKcSsRRAkV7UasQUBHdxgr57oDjOaU6cbrdFeHXsCd4vY7IhrGsR2I2ilpR kXjHmlgMjryL8O8/cnN68Ze3yNly8HOjZtCSwpMGja31FQ7qZlm+u2EN0EtCNgcf2tt0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFEPd-00064j-Ax; Mon, 07 Sep 2020 12:30:15 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUrR6MsTq9ec7px h8ZcdsFLZ7qps9SZptCKmMpxgb21vto5X8L////C3AL4AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QJ BwoLHCukqa4AAAEuSURBVDjLrZPBSsNAEIZn32DGstBraFXwJpuaXotVvNa6UuhJqd3gsTQ29CYF iWfBV+jZQ9/PTdoEG2YKBYdAlv34d+b/swEFhLAtpD8FSuVAKVS0V5BvACIS1gEo8iLMn5qidsa2 8BCg/wHkLUgAkAc+EgHQ0QAFgJIi96F4wIdVAFbhx2LbeIMogaPHLb0j7TXz6QoKKZNCwPooNkFQ MIXFNy8ubx3sXopYwGdI3FwgKwSA8i0hCYixHziK/6cATxrtsG8D3Rk+9MJhu1c5vz1LM9d6akbP 7tssriZVj7d49vWZTZrnL/FFN47mFQg696dk7uxs1Ho316GtmqdBdJn1b5I0bKyM6RqzA3qRTMO1 c0m8fnTL1+X0o1RoGpDVm8HYamtXc7vhI/kpF7+VDmRfLEfkkgAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0wOS0wN1QxMDoxMToyOCswMDowMO2vH8gAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDkt MDdUMTA6MTE6MjgrMDA6MDCc8qd0AAAAAElFTkSuQmCC X-Now-Playing: Artful Dodger's _It's All About the Stragglers_: "What You Gonna Do? feat. Craig David" In-Reply-To: <87tuwaoj6g.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 06 Sep 2020 19:26:47 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187423 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > I've had a look at the original problem that triggered this, and I > wonder if this much simpler patch wouldn't be preferable. For one, it > doesn't touch the minibuffer.el machinery (which is complicated as it > is) or has any kind of complicated caching semantics. It just binds a > different command to RET in icomplete-minibuffer-map, presumably solving > 19032 (in my limited testing). It's also guaranteed not to affect > fido-mode. That does look like a much simpler and less invasive way to implement this; yes. (And you'd presumably remove the stuff that was added for 19032 already?) But I was wondering whether there were any other use cases where the newly added stuff would be useful... but perhaps not? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no