From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form Date: Sun, 13 Sep 2020 14:44:45 +0200 Message-ID: <87a6xtzw02.fsf@gnus.org> References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="741"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 13 14:45:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHRNW-000AbW-2D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 14:45:10 +0200 Original-Received: from localhost ([::1]:43946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHRNV-0005py-48 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 08:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHRNO-0005pq-3s for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 08:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHRNN-0002MN-Pw for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 08:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHRNN-0007F3-Oi for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 08:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43329-submit@debbugs.gnu.org id=B43329.160000109727816 (code B ref 43329); Sun, 13 Sep 2020 12:45:01 +0000 Original-Received: (at 43329) by debbugs.gnu.org; 13 Sep 2020 12:44:57 +0000 Original-Received: from localhost ([127.0.0.1]:49660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRNJ-0007Ea-4N for submit@debbugs.gnu.org; Sun, 13 Sep 2020 08:44:57 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRNI-0007EN-4L for 43329@debbugs.gnu.org; Sun, 13 Sep 2020 08:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V7Msq+MBEI5fIVdkBJyaRTRRXSasFhbi5sv+hCD7CFI=; b=EOJke+d/M59W5N6inxEEWaPXNr Q2I0HC4JZ8B5ssn1I4VX9Ey10rNZFPnJQw6nisCOLl8ZW4KlQIm5OEEvmJdJH/yXAqj+gP6wIQUzB Ks20cjYZUUiBE+DGlsFGrIyFNiuu+LdO3hGmerBrv8ly+jKhWY1FONGXsJ5b9OiL07eg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHRN9-00030f-66; Sun, 13 Sep 2020 14:44:49 +0200 X-Now-Playing: =?UTF-8?Q?R=C3=B3is=C3=ADn?= Murphy's _Play Thing_: "Play Thing" In-Reply-To: (Stefan Monnier's message of "Sat, 12 Sep 2020 11:48:21 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187935 Archived-At: Stefan Monnier writes: >> Would something as simple as the following (which fixes this use case) >> be the correct fix? It only indents these forms as macros if they are >> top-level... > > It obviously has the downside of not indenting properly those > definitions which are not at the very-top level. E.g. definitions > inside an `eval-when-compile` or other. That's true. I guess the (def* calls can happen at any level, really. But the (def* thing is a heuristic, and we could say that we only use that heuristic at the top level? We should then mark all the (def* things we have in-tree with explicit indentation marking (which I think we should do anyway, really). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no