From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39823: 26.3; update-directory-autoloads regression from Emacs 26 to Emacs 27 Date: Wed, 30 Sep 2020 17:23:21 +0200 Message-ID: <87a6x747bq.fsf@gnus.org> References: <87zhd2lpad.fsf@gmail.com> <87o8t16q5e.fsf@gmail.com> <87y2rz4tgb.fsf@gmail.com> <87blo2k4wp.fsf@gmail.com> <83369eqyij.fsf@gnu.org> <87wo6qhqvd.fsf@gmail.com> <835ze9pzfq.fsf@gnu.org> <87mu78jhgz.fsf@gmail.com> <868sir8y85.fsf@gmail.com> <87mu4vn3kz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40029"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39823@debbugs.gnu.org, rms@gnu.org, Noam Postavsky To: Maxim Cournoyer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 17:29:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNe2b-000A9Q-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 17:29:13 +0200 Original-Received: from localhost ([::1]:49184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNe2Z-0002M1-Ll for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 11:29:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNdxa-0004gr-CP for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 11:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNdxa-0006uX-1m for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 11:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNdxZ-0007QJ-PY for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 11:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 15:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39823 X-GNU-PR-Package: emacs Original-Received: via spool by 39823-submit@debbugs.gnu.org id=B39823.160147942528506 (code B ref 39823); Wed, 30 Sep 2020 15:24:01 +0000 Original-Received: (at 39823) by debbugs.gnu.org; 30 Sep 2020 15:23:45 +0000 Original-Received: from localhost ([127.0.0.1]:60814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdxJ-0007Pi-3O for submit@debbugs.gnu.org; Wed, 30 Sep 2020 11:23:45 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdxH-0007PU-DK for 39823@debbugs.gnu.org; Wed, 30 Sep 2020 11:23:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vGQkQ7fSClCfB2gtHKJ276Uqr7DPylyHP9Tos8n5psY=; b=H5kSzNlFuwf3Y244v97sJVXhX5 O3iCxr8wOsPcz9U2lYr7ukCVEjCFz0UJ9XOYnFY8gXTBBnNFdmfL31TPD+4PJ7gzapR9R0PMX0Vj2 NS166oRx2SCLVAzwXWfI4NnJVlR/YmZQaTetTXoMhzWFS+1Ype5kB6azoVa0GwZj3szE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNdwy-0002uj-D0; Wed, 30 Sep 2020 17:23:36 +0200 X-Now-Playing: Rhythm King And Her Friends's _Rhythm King And Her Friends_: "Freia" In-Reply-To: <87mu4vn3kz.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 22 Jun 2020 00:10:04 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189364 Archived-At: Maxim Cournoyer writes: > I've given this idea a try with the attached patch. For some reason I > can't seem to simply eval the definition to test it (Debugger > entered--Lisp error: (void-function byte-compile-info-string). I'm > rebuilding Emacs with the change right now. [...] > This provides a way to explicitly specify the GENERATED-AUTOLOAD-FILE > file name to use for the generated autoload definitions, which is more > convenient when using lexical scoping. Previously, the user had to > use dynamic scoping and bind the variable before calling > `update-directory-autoloads'. This was discussed in > . This seems like a good change -- I'm all for explicit function arguments instead of binding variables around the call. [...] > ;;;###autoload > -(defun update-directory-autoloads (&rest dirs) > +(cl-defun update-directory-autoloads (&rest dirs > + &key (generated-autoload-file > + generated-autoload-file) > + &allow-other-keys) But I'm not really enthusiastic about this complicated function signature. The doc string to the function already goes on way too long to explain what the parameter means. I think it would make more sense to introduce a new function, say, `make-directory-autoloads' (because it doesn't so much update the autoloads as create an autoload file, I think?) with a sane function signature, and then deprecate update-directory-autoloads (which is only used a handful of place in the Emacs tree). Any comments? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no