From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42013: 26.3; hash tables are not garbage collected Date: Sat, 17 Oct 2020 12:52:40 +0200 Message-ID: <87a6wlt98n.fsf@gnus.org> References: <87zh8uwxn3.fsf@cert.kernkonzept.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5534"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42013@debbugs.gnu.org To: Hendrik Tews Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 17 12:53:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTjps-0001KH-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 12:53:16 +0200 Original-Received: from localhost ([::1]:45558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTjpr-0001gJ-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 06:53:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTjpe-0001f9-Gv for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 06:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTjpe-0007zG-7R for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 06:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTjpe-000231-0l for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 06:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 10:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42013 X-GNU-PR-Package: emacs Original-Received: via spool by 42013-submit@debbugs.gnu.org id=B42013.16029319817864 (code B ref 42013); Sat, 17 Oct 2020 10:53:01 +0000 Original-Received: (at 42013) by debbugs.gnu.org; 17 Oct 2020 10:53:01 +0000 Original-Received: from localhost ([127.0.0.1]:33551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTjpc-00022m-Qz for submit@debbugs.gnu.org; Sat, 17 Oct 2020 06:53:01 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTjpa-00022W-NR for 42013@debbugs.gnu.org; Sat, 17 Oct 2020 06:52:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=llPYVPHFIMA6GQQSbv10kgFWKOz9dkQCFKK/SdZLDBk=; b=g9WeydvIkMaDq42VM89lCbqLf9 XE2wklFNiywJPT5SYYge+m0P0Y2Wk+GVfvrr+1UxwTiJNCGiVDkHy/+c8339UwIXFx8ujqxHzgR4W YJEKH9T8Kt70diaNFJT9rkxQU/BQyp4+YHJHKk5iysxSifZLOhjgDMkNChGjJK1MI3fI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTjpK-0002ma-4D; Sat, 17 Oct 2020 12:52:52 +0200 X-Now-Playing: Machinedrum's _Vapor City Citizenship Programme_: "Vapor City - Vizion Centre Mix" In-Reply-To: <87zh8uwxn3.fsf@cert.kernkonzept.com> (Hendrik Tews's message of "Tue, 23 Jun 2020 00:20:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190799 Archived-At: Hendrik Tews writes: > What am I doing wrong that prevents the third call to > garbage-collect to garbage collect the hash and the uninterned > symbol? (let (gc-start gc-state hash result) ;; record gc statistics (setq gc-start (garbage-collect)) (setq hash (make-hash-table)) (setq gc-state (garbage-collect)) (push (list 'vec1 (- (caddr (assoc 'vectors gc-state)) (caddr (assoc 'vectors gc-start)))) result) ;; make the hash inaccessible (setq hash nil) (setq gc-state (garbage-collect)) (push (list 'vec2 (- (caddr (assoc 'vectors gc-state)) (caddr (assoc 'vectors gc-start)))) result) result) I've simplified the test case. As the bug submitter says, there's more vectors after this than before: ((vec2 5) (vec1 5)) But I'm not sure you can use this data in this fine-grained way. For instance: (let (gc-start gc-state hash result) ;; record gc statistics (setq gc-start (garbage-collect)) ;;(setq hash (make-hash-table)) (setq gc-state (garbage-collect)) (push (list 'vec1 (- (caddr (assoc 'vectors gc-state)) (caddr (assoc 'vectors gc-start)))) result) ;; make the hash inaccessible (setq hash nil) (setq gc-state (garbage-collect)) (push (list 'vec2 (- (caddr (assoc 'vectors gc-state)) (caddr (assoc 'vectors gc-start)))) result) result) => ((vec2 0) (vec1 0)) Sounds good. (let (gc-start gc-state hash result) ;; record gc statistics (setq gc-start (garbage-collect)) (make-hash-table) (setq gc-state (garbage-collect)) (push (list 'vec1 (- (caddr (assoc 'vectors gc-state)) (caddr (assoc 'vectors gc-start)))) result) ;; make the hash inaccessible (setq hash nil) (setq gc-state (garbage-collect)) (push (list 'vec2 (- (caddr (assoc 'vectors gc-state)) (caddr (assoc 'vectors gc-start)))) result) result) => ((vec2 -1) (vec1 4)) Uhmn... So I'm not sure there's anything to fix here, except perhaps noting in the doc string that you can't do precision math on the numbers? Anybody? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no