bug#41696: 27.0.91; comment-line in js-jsx-mode does not handle ReactJS markup

bug#41696: 27.0.91; comment-line in js-jsx-mode does not handle ReactJS markup

[Brian Leung]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

With the following example code:

import * as React from "react";
import { render } from "react-dom";

const App = () => {
  return (
    <React.StrictMode>
      <div>Hello</div>
    </React.StrictMode>
  );
};

render(<App />, document.getElementById("root"));


If you move to the live with the <div> and call M-x comment-line, the
line is commented out with two forward slashes, instead of the proper

{{/* <div>Hello</div> */}}

In GNU Emacs 27.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20)
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: NixOS 20.09 (Nightingale)

[-- Attachment #2: Type: text/html, Size: 833 bytes --]

bug#41696: 27.0.91; comment-line in js-jsx-mode does not handle ReactJS markup

[Lars Ingebrigtsen]

Brian Leung <bkleung89@gmail.com> writes:

> If you move to the live with the <div> and call M-x comment-line, the
> line is commented out with two forward slashes, instead of the proper
>
> {{/* <div>Hello</div> */}}

I know nothing about JSX, but googling for three seconds seems to say
that the comment syntax is

{/* <div>Hello</div> */}

?  In any case, I've now made js-jsx-mode comment lines in this way if
inside a JSX block.  But like I said, I don't really know the language,
so it'd be nice if somebody else gave it a look-over.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no